Issue 12395022: [Telemtry] Set --enable-remote-debugging flag for Android.

Issue 12395022: [Telemtry] Set --enable-remote-debugging flag for Android. (Closed)

Created:
7 years, 9 months ago by frankf

Modified:
7 years, 9 months ago

Reviewers:
bulach

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Set --enable-remote-debugging flag for Android. Eventually, this will enable us to remove the current hack for starting the devtools server. NOTRY=True BUG=177053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186211

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! tiny nit: https://codereview.chromium.org/12395022/diff/1/tools/telemetry/telemetry/core/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right): https://codereview.chromium.org/12395022/diff/1/tools/telemetry/telemetry/core/chrome/android_browser_backend.py#newcode78 tools/telemetry/telemetry/core/chrome/android_browser_backend.py:78: # TODO: Once --enable-remote-debugging flag ...

7 years, 9 months ago (2013-03-05 09:37:41 UTC) #2

frankf

https://codereview.chromium.org/12395022/diff/1/tools/telemetry/telemetry/core/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right): https://codereview.chromium.org/12395022/diff/1/tools/telemetry/telemetry/core/chrome/android_browser_backend.py#newcode78 tools/telemetry/telemetry/core/chrome/android_browser_backend.py:78: # TODO: Once --enable-remote-debugging flag makes its way to ...

7 years, 9 months ago (2013-03-05 18:36:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/12395022/5001

7 years, 9 months ago (2013-03-05 18:37:48 UTC) #4

Message was sent while issue was closed.

Change committed as 186211

Expand Messages | Collapse Messages