Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/telemetry/telemetry/core/chrome/android_browser_backend.py

Issue 12395022: [Telemtry] Set --enable-remote-debugging flag for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/chrome/android_browser_backend.py
index 6bdc2232b7219d5b07e08192e58af15f36060796..6b4ffffc1332e617d42a5802ebd04c5f2569ee75 100644
--- a/tools/telemetry/telemetry/core/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/chrome/android_browser_backend.py
@@ -75,6 +75,8 @@ class AndroidBrowserBackend(browser_backend.BrowserBackend):
args = map(QuoteIfNeeded, args)
self._adb.Adb().SetProtectedFileContents(cmdline_file, ' '.join(args))
+ # TODO: Once --enable-remote-debugging flag makes its way to the oldest
+ # version under test (m27 goes to stable), remove this hack.
# Force devtools protocol on, if not already done and we can access
# protected files.
if (not is_content_shell and
@@ -144,6 +146,7 @@ class AndroidBrowserBackend(browser_backend.BrowserBackend):
def GetBrowserStartupArgs(self):
args = super(AndroidBrowserBackend, self).GetBrowserStartupArgs()
+ args.append('--enable-remote-debugging')
args.append('--disable-fre')
return args
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698