Chromium Code Reviews| Index: chrome_frame/protocol_sink_wrap.cc |
| =================================================================== |
| --- chrome_frame/protocol_sink_wrap.cc (revision 185939) |
| +++ chrome_frame/protocol_sink_wrap.cc (working copy) |
| @@ -871,9 +871,8 @@ |
| IInternetProtocol* protocol, |
| DWORD options) { |
| scoped_refptr<ProtData> prot_data = ProtData::DataFromProtocol(protocol); |
| - // TODO(ananta/robertshield) |
| - // Write a test for this bug http://crbug.com/178421 |
| - if (prot_data && !IsChrome(prot_data->renderer_type())) |
| + if (prot_data && !IsChrome(prot_data->renderer_type()) && |
|
robertshield
2013/03/04 19:40:39
Please could you add a fairly detailed comment exp
ananta
2013/03/04 19:52:50
Done.
|
| + !prot_data->is_attach_external_tab_request()) |
| prot_data->Invalidate(); |
| // We are just pass through at this point, avoid false positive crash |