Fix a crash seen in ChromeFrame when opening a non CF top level tab from a CF page.

chrome_frame/protocol_sink_wrap.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <htiframe.h>
 #include <mshtml.h>
 
 #include "chrome_frame/protocol_sink_wrap.h"
 
 #include "base/logging.h"
@@ skipping 853 matching lines @@
   // We are just pass through at this point, avoid false positive crash
   // reports.
   ExceptionBarrierReportOnlyModule barrier;
   return orig_req(protocol, hr, options);
 }
 
 STDMETHODIMP Hook_Terminate(InternetProtocol_Terminate_Fn orig_req,
                             IInternetProtocol* protocol,
                             DWORD options) {
   scoped_refptr<ProtData> prot_data = ProtData::DataFromProtocol(protocol);
-  // TODO(ananta/robertshield)
-  // Write a test for this bug http://crbug.com/178421
-  if (prot_data && !IsChrome(prot_data->renderer_type()))
+  if (prot_data && !IsChrome(prot_data->renderer_type()) &&

[robertshield, 2013/03/04 19:40:39]

Please could you add a fairly detailed comment explaining why we don't
invalidate the ProtData for Chrome-renderers or for external tab requests?

[ananta, 2013/03/04 19:52:50]

Done.

+      !prot_data->is_attach_external_tab_request())
     prot_data->Invalidate();
 
   // We are just pass through at this point, avoid false positive crash
   // reports.
   ExceptionBarrierReportOnlyModule barrier;
   return orig_req(protocol, options);
 }
 
 // Patching / Hooking code.
 class FakeProtocol : public CComObjectRootEx<CComSingleThreadModel>,
@@ skipping 97 matching lines @@
     // Explicit release, otherwise ~CComObjectStackEx will complain about
     // outstanding reference to us, because it runs before ~FakeProtocol
     prot.transaction_.Release();
   }
 }
 
 void TransactionHooks::RevertHooks() {
   vtable_patch::UnpatchInterfaceMethods(CTransaction_PatchInfo);
   vtable_patch::UnpatchInterfaceMethods(CTransaction2_PatchInfo);
 }