Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 12390017: Separating ONC<->Shill translation from the ONC signature. (Closed)

Created:
7 years, 9 months ago by pneubeck (no reviews)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Moves the mapping between Shill's and ONC's field names out of the ONC signature into separate tables. Adds a base_signature pointer to ONC value signatures and uses that to define an derived signatures with additional state fields. The advantage of such derived ONC signatures is that we can have specialized validation that don't influence each other: - ONC with readonly state from Shill - ONC from UI (like the JS extension API) Both will be derived from standard ONC. This commit adds the first of these two specializations: ONC with Shill's state information. TBR=stevenjb@chromium.org (for test/data changes) BUG=147614, 157696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186156

Patch Set 1 : Initial patch. #

Patch Set 2 : Fixed browser tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+622 lines, -409 lines) Patch
M chrome/browser/chromeos/extensions/networking_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/networking_private_event_router.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking/test.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/onc/onc_constants.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_constants.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_mapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_signature.h View 4 chunks +6 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 4 chunks +191 lines, -222 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.h View 2 chunks +19 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 4 chunks +189 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 11 chunks +48 lines, -29 lines 0 comments Download
M chromeos/network/onc/onc_translator_unittest.cc View 2 chunks +31 lines, -43 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 14 chunks +29 lines, -61 lines 0 comments Download
M chromeos/network/onc/onc_validator_unittest.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M chromeos/test/data/network/invalid_settings_with_repairs.json View 2 chunks +30 lines, -0 lines 0 comments Download
A + chromeos/test/data/network/shill_wifi_with_state.json View 1 chunk +4 lines, -0 lines 0 comments Download
A chromeos/test/data/network/translation_of_shill_l2tpipsec.onc View 1 chunk +22 lines, -0 lines 0 comments Download
A chromeos/test/data/network/translation_of_shill_wifi_with_state.onc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Greg Spencer (Chromium)
LGTM. I like this arrangement: it's easier to follow and more flexible.
7 years, 9 months ago (2013-03-01 23:48:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12390017/2017
7 years, 9 months ago (2013-03-04 09:24:56 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=117737
7 years, 9 months ago (2013-03-04 10:51:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12390017/12002
7 years, 9 months ago (2013-03-05 09:49:23 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 11:52:49 UTC) #5
Message was sent while issue was closed.
Change committed as 186156

Powered by Google App Engine
This is Rietveld 408576698