Hide the add new profile menu item for managed users.

Hide the add new profile menu item for managed users.
Extracted from the changelist here:
https://chromiumcodereview.appspot.com/12379014/

BUG=171370
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186188

[Adrian Kuegel, 2013-03-04 09:47:34]

Peter, can you please look at this changelist? I had to extract it from the
other changelist because the base file was missing. I added a comment in the
header like you suggested.

[Peter Kasting, 2013-03-04 19:22:57]

In the future you might want to try to re-upload as opposed to using a new
changelist, but it's not a big deal.

https://codereview.chromium.org/12388073/diff/1/chrome/browser/ui/views/avata...
File chrome/browser/ui/views/avatar_menu_bubble_view.h (right):

https://codereview.chromium.org/12388073/diff/1/chrome/browser/ui/views/avata...
chrome/browser/ui/views/avatar_menu_bubble_view.h:82: views::Link*
add_profile_link_;
Nit: Might be clearer to move this down to below separator and then comment
like:

  // These will be non-NULL iff
  // avatar_menu_model_->ShouldShowAddNewProfileLink() returns true.  See
  // OnAvatarMenuModelChanged().
  views::Separator* separator_;
  views::Link* add_profile_link_;

This also keeps the members in roughly the same order that they visually appear,
which seems good.

Note that this will require changing the initializer order and such to match
this changed declaration order.

[Adrian Kuegel, 2013-03-04 21:40:54]

I tried to re-upload the patch in the old changelist, but it didn't help. I
found it written somewhere in an email thread that a re-upload only helps if the
first patch is ok, which was not the case here. Anyway, I should have noticed it
that the first patch in the old changelist was missing a base file before asking
for reviews. Sorry for that.

https://codereview.chromium.org/12388073/diff/1/chrome/browser/ui/views/avata...
File chrome/browser/ui/views/avatar_menu_bubble_view.h (right):

https://codereview.chromium.org/12388073/diff/1/chrome/browser/ui/views/avata...
chrome/browser/ui/views/avatar_menu_bubble_view.h:82: views::Link*
add_profile_link_;
On 2013/03/04 19:22:57, Peter Kasting wrote:
> Nit: Might be clearer to move this down to below separator and then comment
> like:
> 
>   // These will be non-NULL iff
>   // avatar_menu_model_->ShouldShowAddNewProfileLink() returns true.  See
>   // OnAvatarMenuModelChanged().
>   views::Separator* separator_;
>   views::Link* add_profile_link_;
> 
> This also keeps the members in roughly the same order that they visually
appear,
> which seems good.
> 
> Note that this will require changing the initializer order and such to match
> this changed declaration order.

Done.

[Peter Kasting, 2013-03-04 23:03:08]

LGTM

https://codereview.chromium.org/12388073/diff/5001/chrome/browser/ui/views/av...
File chrome/browser/ui/views/avatar_menu_bubble_view.cc (right):

https://codereview.chromium.org/12388073/diff/5001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_menu_bubble_view.cc:431: add_profile_link_(NULL),
These two members need to be in the correct order relative to the others (i.e.
they both need to move down below |browser_|).

[commit-bot: I haz the power, 2013-03-05 13:32:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/12388073/9001

[commit-bot: I haz the power, 2013-03-05 16:50:02]

Change committed as 186188