Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2772)

Unified Diff: chrome/browser/autofill/wallet/wallet_address_unittest.cc

Issue 12388059: Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/wallet/wallet_address.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/wallet/wallet_address_unittest.cc
diff --git a/chrome/browser/autofill/wallet/wallet_address_unittest.cc b/chrome/browser/autofill/wallet/wallet_address_unittest.cc
index 747e034edd608955d95d17ca63f6b5f4ef6d008f..57ce0aba58ea66651f1e1e47bf0dbd2f5200441c 100644
--- a/chrome/browser/autofill/wallet/wallet_address_unittest.cc
+++ b/chrome/browser/autofill/wallet/wallet_address_unittest.cc
@@ -166,23 +166,40 @@ class WalletAddressTest : public testing::Test {
scoped_ptr<const DictionaryValue> dict_;
};
+TEST_F(WalletAddressTest, CreateAddressMissingObjectId) {
+ SetUpDictionary(kAddressMissingObjectId);
+ Address address("country_name_code",
+ ASCIIToUTF16("recipient_name"),
+ ASCIIToUTF16("address_line_1"),
+ ASCIIToUTF16("address_line_2"),
+ ASCIIToUTF16("locality_name"),
+ ASCIIToUTF16("administrative_area_name"),
+ ASCIIToUTF16("postal_code_number"),
+ ASCIIToUTF16("phone_number"),
+ "");
+ ASSERT_EQ(address, *Address::CreateAddress(*dict_));
+}
+
TEST_F(WalletAddressTest, CreateAddressWithIDMissingObjectId) {
SetUpDictionary(kAddressMissingObjectId);
ASSERT_EQ(NULL, Address::CreateAddressWithID(*dict_).get());
}
-TEST_F(WalletAddressTest, CreateAddressWithIDMissingCountryNameCode) {
+TEST_F(WalletAddressTest, CreateAddressMissingCountryNameCode) {
SetUpDictionary(kAddressMissingCountryNameCode);
+ ASSERT_EQ(NULL, Address::CreateAddress(*dict_).get());
ASSERT_EQ(NULL, Address::CreateAddressWithID(*dict_).get());
}
-TEST_F(WalletAddressTest, CreateAddressWithIDMissingRecipientName) {
+TEST_F(WalletAddressTest, CreateAddressMissingRecipientName) {
SetUpDictionary(kAddressMissingRecipientName);
+ ASSERT_EQ(NULL, Address::CreateAddress(*dict_).get());
ASSERT_EQ(NULL, Address::CreateAddressWithID(*dict_).get());
}
-TEST_F(WalletAddressTest, CreateAddressWithIDMissingPostalCodeNumber) {
+TEST_F(WalletAddressTest, CreateAddressMissingPostalCodeNumber) {
SetUpDictionary(kAddressMissingPostalCodeNumber);
+ ASSERT_EQ(NULL, Address::CreateAddress(*dict_).get());
ASSERT_EQ(NULL, Address::CreateAddressWithID(*dict_).get());
}
@@ -197,6 +214,7 @@ TEST_F(WalletAddressTest, CreateAddressWithID) {
ASCIIToUTF16("postal_code_number"),
ASCIIToUTF16("phone_number"),
"id");
+ ASSERT_EQ(address, *Address::CreateAddress(*dict_));
ASSERT_EQ(address, *Address::CreateAddressWithID(*dict_));
}
« no previous file with comments | « chrome/browser/autofill/wallet/wallet_address.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698