Issue 12388059: Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses).

Issue 12388059: Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses). (Closed)

Created:
7 years, 9 months ago by Dan Beam

Modified:
7 years, 9 months ago

Reviewers:
ahutter, Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses). R=isherman@chromium.org,ahutter@chromium.org BUG=163505 TEST=unit, Save*Address()/GetFullWallet() works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186049

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : . #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -74 lines)			Patch
M	chrome/browser/autofill/wallet/full_wallet.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autofill/wallet/full_wallet_unittest.cc	View	1	4 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/wallet/wallet_address.h	View	1 2 3 4	1 chunk	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/autofill/wallet/wallet_address.cc	View	1 2 3	2 chunks	+77 lines, -62 lines	0 comments	Download
M	chrome/browser/autofill/wallet/wallet_address_unittest.cc	View	1 2 3	2 chunks	+21 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

I'm going to wait for ahutter@, I can't remember exactly why I needed to do ...

7 years, 9 months ago (2013-03-04 19:46:50 UTC) #4

ahutter

https://chromiumcodereview.appspot.com/12388059/diff/2007/chrome/browser/autofill/wallet/wallet_address.h File chrome/browser/autofill/wallet/wallet_address.h (right): https://chromiumcodereview.appspot.com/12388059/diff/2007/chrome/browser/autofill/wallet/wallet_address.h#newcode104 chrome/browser/autofill/wallet/wallet_address.h:104: // IDs are not currently required or returns for ...

7 years, 9 months ago (2013-03-04 21:35:52 UTC) #6

Dan Beam

check out updated wording? right now? https://chromiumcodereview.appspot.com/12388059/diff/2007/chrome/browser/autofill/wallet/wallet_address.h File chrome/browser/autofill/wallet/wallet_address.h (right): https://chromiumcodereview.appspot.com/12388059/diff/2007/chrome/browser/autofill/wallet/wallet_address.h#newcode104 chrome/browser/autofill/wallet/wallet_address.h:104: // IDs are ...

7 years, 9 months ago (2013-03-04 21:50:53 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/12388059/5005

7 years, 9 months ago (2013-03-04 22:25:32 UTC) #9

Message was sent while issue was closed.

Change committed as 186049

Expand Messages | Collapse Messages