Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: chrome/browser/autofill/wallet/full_wallet_unittest.cc

Issue 12388059: Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/wallet/full_wallet.cc ('k') | chrome/browser/autofill/wallet/wallet_address.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/wallet/full_wallet_unittest.cc
diff --git a/chrome/browser/autofill/wallet/full_wallet_unittest.cc b/chrome/browser/autofill/wallet/full_wallet_unittest.cc
index b2678b9f6157e2f8cace0214ecfbb6ad1b482729..4a3133e2b414db6f3c14e4b03796445bab5c63d6 100644
--- a/chrome/browser/autofill/wallet/full_wallet_unittest.cc
+++ b/chrome/browser/autofill/wallet/full_wallet_unittest.cc
@@ -21,7 +21,6 @@ const char kFullWalletValidResponse[] =
" \"rest\":\"rest\","
" \"billing_address\":"
" {"
- " \"id\":\"id\","
" \"phone_number\":\"phone_number\","
" \"postal_address\":"
" {"
@@ -304,7 +303,6 @@ const char kFullWalletMalformedBillingAddress[] =
" \"rest\":\"rest\","
" \"billing_address\":"
" {"
- " \"id\":\"id\","
" \"phone_number\":\"phone_number\","
" \"postal_address\":"
" {"
@@ -427,6 +425,7 @@ TEST_F(FullWalletTest, CreateFullWalletWithInvalidRequiredActions) {
TEST_F(FullWalletTest, CreateFullWallet) {
SetUpDictionary(kFullWalletValidResponse);
+ // NOTE: FullWallet billing address doesn't require an ID.
scoped_ptr<Address> billing_address(new Address(
"country_name_code",
ASCIIToUTF16("recipient_name"),
@@ -436,7 +435,7 @@ TEST_F(FullWalletTest, CreateFullWallet) {
ASCIIToUTF16("administrative_area_name"),
ASCIIToUTF16("postal_code_number"),
ASCIIToUTF16("phone_number"),
- "id"));
+ ""));
scoped_ptr<Address> shipping_address(new Address(
"ship_country_name_code",
ASCIIToUTF16("ship_recipient_name"),
« no previous file with comments | « chrome/browser/autofill/wallet/full_wallet.cc ('k') | chrome/browser/autofill/wallet/wallet_address.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698