Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2334)

Unified Diff: chrome/browser/autofill/wallet/wallet_address.h

Issue 12388059: Adds wallet::Address::CreateAddress() for when IDs are optional (for billing addresses). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/wallet/wallet_address.h
diff --git a/chrome/browser/autofill/wallet/wallet_address.h b/chrome/browser/autofill/wallet/wallet_address.h
index 980470991ea8a147807404122a06296329a184cd..5fe2882ad3e9c047651ed0c27fc92c5c1966c887 100644
--- a/chrome/browser/autofill/wallet/wallet_address.h
+++ b/chrome/browser/autofill/wallet/wallet_address.h
@@ -100,14 +100,22 @@ class Address {
string16 GetInfo(AutofillFieldType type) const;
// Returns an empty scoped_ptr if input is invalid or a valid address that is
- // selectable for Google Wallet use.
- static scoped_ptr<Address>
- CreateAddressWithID(const base::DictionaryValue& dictionary);
+ // selectable for Google Wallet use. Does not require "id" in |dictionary|.
+ // IDs are not currently required or returns for billing addresses not in a
ahutter 2013/03/04 21:35:52 "or returned for billing addresses."?
Dan Beam 2013/03/04 21:50:53 Done.
+ // FullWallet.
+ static scoped_ptr<Address> CreateAddress(
+ const base::DictionaryValue& dictionary);
+
+ // Returns an empty scoped_ptr if input is invalid or a valid address that is
+ // selectable for Google Wallet use. Requires "id" in |dictionary|. IDs are
+ // required for shipping address and billing addresses in a FullWallet.
ahutter 2013/03/04 21:35:52 "required for shipping addresses."?
Dan Beam 2013/03/04 21:50:53 Done.
+ static scoped_ptr<Address> CreateAddressWithID(
+ const base::DictionaryValue& dictionary);
// Returns an empty scoped_ptr if input in invalid or a valid address that
// can only be used for displaying to the user.
- static scoped_ptr<Address>
- CreateDisplayAddress(const base::DictionaryValue& dictionary);
+ static scoped_ptr<Address> CreateDisplayAddress(
+ const base::DictionaryValue& dictionary);
bool operator==(const Address& other) const;
bool operator!=(const Address& other) const;
« no previous file with comments | « chrome/browser/autofill/wallet/full_wallet_unittest.cc ('k') | chrome/browser/autofill/wallet/wallet_address.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698