Issue 12388057: Android: Use ObserverList to maintain a list of observers/listeners

Issue 12388057: Android: Use ObserverList to maintain a list of observers/listeners (Closed)

Created:
7 years, 9 months ago by nilesh

Modified:
7 years, 9 months ago

Reviewers:
Ted C, David Trainor- moved to gerrit, Yaron

CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, Raghu Simha, darin-cc_chromium.org, haitaol1, erikwright+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Use ObserverList to maintain a list of observers/listeners Using ObserverList allows for observers adding/removing themselves/others while they are being notified, in a safe way BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186090

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Fix findbugs and Ted's comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -43 lines)			Patch
M	base/android/java/src/org/chromium/base/ActivityStatus.java	View		4 chunks	+4 lines, -8 lines	0 comments	Download
M	build/android/findbugs_filter/findbugs_known_bugs.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/TabBase.java	View	1 2	6 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	net/android/java/src/org/chromium/net/NetworkChangeNotifier.java	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java	View		4 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ted C

lgtm w/ style nit https://chromiumcodereview.appspot.com/12388057/diff/7001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java File chrome/android/java/src/org/chromium/chrome/browser/TabBase.java (right): https://chromiumcodereview.appspot.com/12388057/diff/7001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/TabBase.java:74: observer.onCloseTab(TabBase.this); need braces always in ...

7 years, 9 months ago (2013-03-04 19:09:46 UTC) #3

nilesh

https://codereview.chromium.org/12388057/diff/7001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java File chrome/android/java/src/org/chromium/chrome/browser/TabBase.java (right): https://codereview.chromium.org/12388057/diff/7001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/TabBase.java:74: observer.onCloseTab(TabBase.this); On 2013/03/04 19:09:46, Ted C wrote: > need ...

7 years, 9 months ago (2013-03-04 22:02:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12388057/10001

7 years, 9 months ago (2013-03-04 23:02:19 UTC) #6

Message was sent while issue was closed.

Change committed as 186090

Expand Messages | Collapse Messages