Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: base/android/java/src/org/chromium/base/ActivityStatus.java

Issue 12388057: Android: Use ObserverList to maintain a list of observers/listeners (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix findbugs and Ted's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/findbugs_filter/findbugs_known_bugs.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/ActivityStatus.java
diff --git a/base/android/java/src/org/chromium/base/ActivityStatus.java b/base/android/java/src/org/chromium/base/ActivityStatus.java
index c89a0f80f902bb4bc0ece7997d79e36594fbd4b3..7d0ee947590a9ff0c58555fbb1ccfae8d3da801e 100644
--- a/base/android/java/src/org/chromium/base/ActivityStatus.java
+++ b/base/android/java/src/org/chromium/base/ActivityStatus.java
@@ -7,8 +7,6 @@ package org.chromium.base;
import android.app.Activity;
import android.os.Looper;
-import java.util.concurrent.CopyOnWriteArrayList;
-
/**
* Provides information about the parent activity's status.
*/
@@ -29,10 +27,8 @@ public class ActivityStatus {
// testing.
private static int sActivityState;
- // Use CopyOnWriteArrayList to avoid ConcurrentModificationException when a listener tries to
- // remove itself while being notified of a state change.
- private static final CopyOnWriteArrayList<StateListener> sStateListeners =
- new CopyOnWriteArrayList<StateListener>();
+ private static final ObserverList<StateListener> sStateListeners =
+ new ObserverList<StateListener>();
/**
* Interface to be implemented by listeners.
@@ -96,7 +92,7 @@ public class ActivityStatus {
* @param listener Listener to receive state changes.
*/
public static void registerStateListener(StateListener listener) {
- sStateListeners.add(listener);
+ sStateListeners.addObserver(listener);
}
/**
@@ -104,6 +100,6 @@ public class ActivityStatus {
* @param listener Listener that doesn't want to receive state changes.
*/
public static void unregisterStateListener(StateListener listener) {
- sStateListeners.remove(listener);
+ sStateListeners.removeObserver(listener);
}
}
« no previous file with comments | « no previous file | build/android/findbugs_filter/findbugs_known_bugs.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698