Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12382018: Remove HTMLOutputElementCustom which is no longer needed. (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)
Modified:
7 years, 9 months ago
Reviewers:
Anton Muhin
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Remove HTMLOutputElementCustom which is no longer needed. Cleanup HTMLCollectionCustom. Implement MediaElement.controller setter. R=antonm@google.com BUG= Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1115

Patch Set 1 #

Patch Set 2 : Reupload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -85 lines) Patch
M Source/WebCore/bindings/dart/custom/DartHTMLCollectionCustom.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/WebCore/bindings/dart/custom/DartHTMLMediaElementCustom.cpp View 1 chunk +22 lines, -3 lines 0 comments Download
D Source/WebCore/bindings/dart/custom/DartHTMLOutputElementCustom.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M Source/WebCore/bindings/dart/gyp/overrides.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 9 months ago (2013-02-28 16:01:08 UTC) #1
Anton Muhin
lgtm
7 years, 9 months ago (2013-02-28 16:23:10 UTC) #2
Mads Ager (google)
7 years, 9 months ago (2013-03-01 06:55:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698