Rename RemovableDeviceNotifications=>StorageMonitor

Rename RemovableDeviceNotifications=>StorageMonitor

Renamed classes and updated some variable names.

BUG=NONE
TBR=thestig@chromium.org,davemoore@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186030

[vandebo (ex-Chrome), 2013-02-28 20:02:40]

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
File chrome/browser/chrome_browser_main_linux.h (right):

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
chrome/browser/chrome_browser_main_linux.h:37:
scoped_refptr<chrome::StorageMonitorLinux>
Remove new line.

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
File chrome/browser/chrome_browser_main_mac.h (right):

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
chrome/browser/chrome_browser_main_mac.h:32:
scoped_refptr<chrome::RemovableDeviceNotificationsMac>
Class name...

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/12382005/diff/1/chrome/browser/chrome_browser...
chrome/browser/chrome_browser_main_mac.mm:286: new
chrome::RemovableDeviceNotificationsMac();
and here

https://codereview.chromium.org/12382005/diff/1/chrome/browser/storage_monito...
File chrome/browser/storage_monitor/storage_monitor_chromeos.h (right):

https://codereview.chromium.org/12382005/diff/1/chrome/browser/storage_monito...
chrome/browser/storage_monitor/storage_monitor_chromeos.h:9: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_
Include guards need to be updated as well.

https://codereview.chromium.org/12382005/diff/1/chrome/browser/storage_monito...
File chrome/browser/storage_monitor/storage_monitor_window_win.h (right):

https://codereview.chromium.org/12382005/diff/1/chrome/browser/storage_monito...
chrome/browser/storage_monitor/storage_monitor_window_win.h:26: class
StorageMonitorWindowWin : public StorageMonitor {
The WindowWin part was unnecessary.  This can be StorageMonitorWin

[tommycli, 2013-03-01 18:26:29]

Believe I finally got all the instances of the old name.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_linux.cc (left):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.cc:126:
"RemovableDeviceNotificationsLinux.device_partition_size_available",
This is still old name. I'll get it in a separate changelog.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.cc:146:
"RemovableDeviceNotificationsLinux.device_file_system_uuid_available",
Samesies.

[commit-bot: I haz the power, 2013-03-01 19:25:15]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[vandebo (ex-Chrome), 2013-03-01 19:47:39]

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main_linux.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main_linux.cc:137: new
chrome::StorageMonitorLinux(kDefaultMtabPath);
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main_mac.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main_mac.h:33: storage_monitor_mac_;
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main_mac.mm:286: new chrome::StorageMonitorMac();
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main_win.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main_win.h:71: storage_monitor_window_;
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:600: new
StorageMonitorCros();
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.h:86: storage_monitor_;
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/media_galle...
File chrome/browser/media_galleries/media_file_system_registry_unittest.cc
(right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/media_galle...
chrome/browser/media_galleries/media_file_system_registry_unittest.cc:405:
scoped_ptr<test::TestStorageMonitorWindowWin> window_;
TestStorageMonitorWin

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/media_galle...
File chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/media_galle...
chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc:27: #include
"chrome/browser/storage_monitor/storage_monitor_win.h"
Is this include needed?

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/portable_device_watcher_win.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/portable_device_watcher_win.h:32: //
StorageMonitorWindowWin. This class is created, destroyed and
StorageMonitorWin x2

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_chromeos.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_chromeos.h:9: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_
update include guards.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_chromeos.h:99: #endif  //
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_
and here

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_linux.cc (left):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.cc:126:
"RemovableDeviceNotificationsLinux.device_partition_size_available",
On 2013/03/01 18:26:29, tommycli wrote:
> This is still old name. I'll get it in a separate changelog.

UMAs are special. A UMA is collecting data from users that have opted in.  So to
rename it means to partition the data. Sometimes that makes sense and sometimes
it doesn't.  I don't think it makes sense in this case.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_linux.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.h:5: // StorageMonitorLinux
listens for mount point changes, notifies
For comments, go ahead and re-linewrap things at 80 col

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.h:9: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_LINUX_H_
Include guards

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux.h:149: #endif  //
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_LINUX_H_
and here

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:137: class
StorageMonitorLinuxTestWrapper
A better name for this would probably be TestStorageMonitorLinux

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:163: class
RemovableDeviceNotificationLinuxTest : public testing::Test {
Missed this class.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_mac.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac.h:5: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_MAC_H_
Header guards

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac.h:69: #endif  //
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_MAC_H_
and here.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_mac.mm (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac.mm:148:
static_cast<StorageMonitorMac*>(context);
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac.mm:159:
static_cast<StorageMonitorMac*>(context);
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac.mm:170: StorageMonitorMac*
notifications =
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm:130: info2,
StorageMonitorMac::UPDATE_DEVICE_CHANGED);
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm:156: info,
StorageMonitorMac::UPDATE_DEVICE_ADDED);
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm:205: info,
StorageMonitorMac::UPDATE_DEVICE_ADDED);
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_win.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:30:
StorageMonitorWin::Create() {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:32: new
VolumeMountWatcherWin(), new PortableDeviceWatcherWin());
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:36: StorageMonitorWin(
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:51: ~StorageMonitorWin() {
nit: line warp.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:67:
StorageMonitorWin::WndProcThunk>,
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:83: StorageInfo*
device_info) const {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:146: HWND hwnd, UINT
message, WPARAM wparam, LPARAM lparam) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:149:
GetWindowLongPtr(hwnd, GWLP_USERDATA));
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:156: HWND hwnd, UINT
message, WPARAM wparam, LPARAM lparam) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:171: uint64*
total_size_in_bytes) const {
reindent; one arg per line, aligned after (

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.cc:181: LPARAM data) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_win.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.h:5: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
Include guards

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.h:20: class
TestStorageMonitorWindowWin;
TestStorageMonitorWin

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.h:56: StorageMonitorWin(
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win.h:97: #endif  //
CHROME_BROWSER_STORAGE_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
and here

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_win_unittest.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:37: class
StorageMonitorWindowWinTest : public testing::Test {
StorageMonitorWinTest

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:80:
StorageMonitorWindowWinTest()
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:86:
~StorageMonitorWindowWinTest() {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:92:
window_.reset(new TestStorageMonitorWindowWin(
this can be indented nicer now.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:124:
volume_mount_watcher_, new TestPortableDeviceWatcherWin));
nit: nicer indent possible.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:150:
DoMassStorageDeviceAttachedTest(const DeviceIndices& device_indices) {
nit: line wrap

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:180:
DoMassStorageDevicesDetachedTest(const DeviceIndices& device_indices) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:207: const
string16& pnp_device_id, bool test_attach) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:338:
DevicesDetachedHighBoundary) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:348:
DevicesDetachedLowBoundary) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:358:
DevicesDetachedAdjacentBits) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:371:
DuplicateAttachCheckSuppressed) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:484:
MTPDeviceWithMultipleStorageObjects) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:501:
GetMTPStorageInfoFromDeviceId) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/test_storage_monitor_win.cc (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/test_storage_monitor_win.cc:16:
TestStorageMonitorWindowWin(
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/test_storage_monitor_win.cc:26:
~TestStorageMonitorWindowWin() {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/test_storage_monitor_win.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/test_storage_monitor_win.h:8: #ifndef
CHROME_BROWSER_STORAGE_MONITOR_TEST_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
update include guards.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/test_storage_monitor_win.h:23: : public
StorageMonitorWin {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/test_storage_monitor_win.h:42: #endif  //
CHROME_BROWSER_STORAGE_MONITOR_TEST_REMOVABLE_DEVICE_NOTIFICATIONS_WINDOW_WIN_H_
and here.

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/volume_mount_watcher_win.h (right):

https://codereview.chromium.org/12382005/diff/5041/chrome/browser/storage_mon...
chrome/browser/storage_monitor/volume_mount_watcher_win.h:26: //
StorageMonitorWindowWin.
nit: line wrap.

[tommycli, 2013-03-01 22:40:34]

Addressed vandebo's comments. Fixed some additional naming and code formatting
issues.

Renamed some notifications_ variables to monitor_.

[vandebo (ex-Chrome), 2013-03-02 00:23:37]

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_mac.mm:286: // TODO(gbillock): Make the
ImageCapture manager owned by
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_win.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_win.cc:203:
chrome::StorageMonitorWin::Create());
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_win.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_win.h:70:
scoped_ptr<chrome::StorageMonitorWin> storage_monitor_window_;
storage_monitor_win_ ?

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chromeos/c...
File chrome/browser/chromeos/chrome_browser_main_chromeos.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chromeos/c...
chrome/browser/chromeos/chrome_browser_main_chromeos.h:90:
scoped_refptr<StorageMonitorCros> storage_monitor_;
Hmm, this is inconsistent with the other platforms, but I think this is better. 
Can you make all of them just storage_monitor_ ?

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/media_gall...
File chrome/browser/media_galleries/media_file_system_registry_unittest.cc
(right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/media_gall...
chrome/browser/media_galleries/media_file_system_registry_unittest.cc:407:
scoped_ptr<test::TestStorageMonitorWin> window_;
window_ -> monitor_ to eliminate the OS dependent name.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/media_gall...
chrome/browser/media_galleries/media_file_system_registry_unittest.cc:782:
window_.reset(new test::TestStorageMonitorWin(
While it takes more lines, I think the following indenting is preferable because
it's easier to read.

 window_.reset(
      new test::TestStorageMonitorWin(new test::TestVolumeMountWatcherWin, 
                                      portable_device_watcher));

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/portable_device_watcher_win.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/portable_device_watcher_win.h:31: // This is a
singleton class instantiated by
re-line wrap

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_chromeos.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_chromeos.cc:110: base::Bind(
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_chromeos.cc:151:
&StorageMonitorCros::CheckMountedPathOnFileThread,
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_chromeos.cc:209: this,
mount_info, has_dcim));
'this,' will fit on the previous line

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_linux.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:228: const
base::FilePath& path)
nit: line wrap

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:236: GetDeviceInfoFunc
get_device_info_func)
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:260: StorageInfo*
device_info) const {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:281: const std::string&
location) const {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:289: const
base::FilePath& path,
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:235: // as a
media directory.
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:242: // does
not recognizes it as a media directory.
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_mac.mm (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:82: UpdateType
update_type) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:115: StorageInfo*
device_info) const {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:136: const std::string&
location) const {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:146: void* context) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:154: void* context) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac.mm:163: void *context) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm:174:
mount_point_.AppendASCII("foo"), &info));
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/test_storage_monitor_win.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/test_storage_monitor_win.cc:19:
portable_device_watcher) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/test_storage_monitor_win.cc:29: DWORD data) {
nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/test_storage_monitor_win.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/test_storage_monitor_win.h:1: // Copyright (c)
2013 The Chromium Authors. All rights reserved.
This file is no longer detected as copied.  Use the --similarity flag to git cl
upload to fix that.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/test_storage_monitor_win.h:6: // simulate device
changed events for testing.
re-line wrap

[tommycli, 2013-03-04 19:15:09]

Fixed some more formatting issues & renamed all the OS-specific var names no
storage_monitor_.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_win.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_win.h:70:
scoped_ptr<chrome::StorageMonitorWin> storage_monitor_window_;
Made all of them storage_monitor_

On 2013/03/02 00:23:37, vandebo wrote:
> storage_monitor_win_ ?

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chromeos/c...
File chrome/browser/chromeos/chrome_browser_main_chromeos.h (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/chromeos/c...
chrome/browser/chromeos/chrome_browser_main_chromeos.h:90:
scoped_refptr<StorageMonitorCros> storage_monitor_;
Yeah, good idea. I will make all of them storage_monitor_

On 2013/03/02 00:23:37, vandebo wrote:
> Hmm, this is inconsistent with the other platforms, but I think this is
better. 
> Can you make all of them just storage_monitor_ ?

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
File chrome/browser/storage_monitor/storage_monitor_linux.cc (right):

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:260: StorageInfo*
device_info) const {
Wasn't able to rewrap in a reasonable way. The result had the "const {" part
going off of the 80-char limit.

On 2013/03/02 00:23:37, vandebo wrote:
> nit: line wrap.

https://codereview.chromium.org/12382005/diff/11063/chrome/browser/storage_mo...
chrome/browser/storage_monitor/storage_monitor_linux.cc:289: const
base::FilePath& path,
The other rewraps were good. Sorry I missed these.

On 2013/03/02 00:23:37, vandebo wrote:
> nit: line wrap.

[vandebo (ex-Chrome), 2013-03-04 20:21:31]

Your issue description is a bit verbose, it's obvious that renaming the class
will involve renaming the files, the classes and the code that references them.

After fixing that and the nits below, LGTM

https://codereview.chromium.org/12382005/diff/3016/chrome/browser/storage_mon...
File chrome/browser/storage_monitor/storage_monitor_win_unittest.cc (right):

https://codereview.chromium.org/12382005/diff/3016/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:91: new
TestStorageMonitorWin(volume_mount_watcher_,
line 91 will fit on line 90 and line 92 will still fit.

https://codereview.chromium.org/12382005/diff/3016/chrome/browser/storage_mon...
chrome/browser/storage_monitor/storage_monitor_win_unittest.cc:122:
monitor_.reset(
same here

[commit-bot: I haz the power, 2013-03-04 20:55:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/12382005/2062

[commit-bot: I haz the power, 2013-03-04 20:56:16]

Presubmit check for 12382005-2062 failed and returned exit status 1.

INFO:root:Found 31 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/chrome_browser_main_linux.cc
    chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    chrome/browser/chrome_browser_main_win.cc
    chrome/browser/chrome_browser_main_win.h
    chromeos/disks/mock_disk_mount_manager.h
    chrome/browser/chrome_browser_main_mac.h
    chrome/chrome_browser_ui.gypi
    chrome/browser/chromeos/chrome_browser_main_chromeos.h
    chrome/chrome_browser.gypi
    chrome/browser/chrome_browser_main_mac.mm
    chrome/browser/chrome_browser_main_linux.h

Presubmit checks took 3.1s to calculate.

[tommycli, 2013-03-04 21:05:07]

TBRing OWNERs due to simple change.

[commit-bot: I haz the power, 2013-03-04 21:05:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/12382005/2062

[commit-bot: I haz the power, 2013-03-04 23:48:44]

Change committed as 186030