Issue 12381042: cc: Only call didCompleteSwapBuffers() when in threaded mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12381042: cc: Only call didCompleteSwapBuffers() when in threaded mode. (Closed)

Created:
7 years, 9 months ago by danakj

Modified:
7 years, 9 months ago

Reviewers:
piman

CC:
chromium-reviews, cc-bugs_chromium.org, backer, slavi, jamesr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Only call didCompleteSwapBuffers() when in threaded mode. Swap buffers complete is the most confusing thing ever. Currently, the didCompleteSwapBuffers callbacks should only happen in threaded mode. In single thread mode, there is instead OnSwapBuffersCompleted which is somehow managed completely outside of the compositor. So, only call didCompleteSwapBuffers from the DelegatingRenderer if we're in thread mode. If we need some mode-agnostic notification we should use a new channel that doesn't have the confusing symantics of the swap buffers code. R=piman BUG=123444 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185586

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	cc/delegating_renderer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12381042/1

7 years, 9 months ago (2013-03-01 18:02:31 UTC) #3

Message was sent while issue was closed.

Change committed as 185586

Expand Messages | Collapse Messages