Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 12379095: Fix up unused includes from chrome/browser/extensions to the rest of chrome/browser. (Closed)

Created:
7 years, 9 months ago by Yoyo Zhou
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry, sky
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix up unused includes from chrome/browser/extensions to the rest of chrome/browser. BUG=159265 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186222

Patch Set 1 #

Total comments: 2

Patch Set 2 : other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M chrome/browser/extensions/active_tab_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_actions.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/activity_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_shortcut_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_shortcut_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/browser_extension_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/context_menu_matcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/dom_actions.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_ui_default.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_warning_set.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoyo Zhou
7 years, 9 months ago (2013-03-05 02:29:41 UTC) #1
Matt Perry
lgtm https://chromiumcodereview.appspot.com/12379095/diff/1/chrome/browser/extensions/api/omnibox/omnibox_api.h File chrome/browser/extensions/api/omnibox/omnibox_api.h (right): https://chromiumcodereview.appspot.com/12379095/diff/1/chrome/browser/extensions/api/omnibox/omnibox_api.h#newcode134 chrome/browser/extensions/api/omnibox/omnibox_api.h:134: void ProfileKeyedAPIFactory<OmniboxAPI>::DeclareFactoryDependencies(); Did you mean to include this ...
7 years, 9 months ago (2013-03-05 02:34:15 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/12379095/diff/1/chrome/browser/extensions/api/omnibox/omnibox_api.h File chrome/browser/extensions/api/omnibox/omnibox_api.h (right): https://chromiumcodereview.appspot.com/12379095/diff/1/chrome/browser/extensions/api/omnibox/omnibox_api.h#newcode134 chrome/browser/extensions/api/omnibox/omnibox_api.h:134: void ProfileKeyedAPIFactory<OmniboxAPI>::DeclareFactoryDependencies(); On 2013/03/05 02:34:15, Matt Perry wrote: > ...
7 years, 9 months ago (2013-03-05 02:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12379095/7003
7 years, 9 months ago (2013-03-05 02:56:23 UTC) #4
commit-bot: I haz the power
Presubmit check for 12379095-7003 failed and returned exit status 1. INFO:root:Found 36 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-05 02:56:38 UTC) #5
Yoyo Zhou
TBR=sky for nonfunctional changes
7 years, 9 months ago (2013-03-05 02:59:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12379095/7003
7 years, 9 months ago (2013-03-05 03:00:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=105105
7 years, 9 months ago (2013-03-05 03:54:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12379095/7003
7 years, 9 months ago (2013-03-05 18:01:17 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 19:14:25 UTC) #10
Message was sent while issue was closed.
Change committed as 186222

Powered by Google App Engine
This is Rietveld 408576698