chrome/browser/extensions/webstore_installer.cc - Issue 12379095: Fix up unused includes from chrome/browser/extensions to the rest of chrome/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 12379095: Fix up unused includes from chrome/browser/extensions to the rest of chrome/browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: other platforms Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/process_management_browsertest.cc ('k') | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 5cb0be8f6d5bfd0f85331b5e6e03cad429c00ceb..4e27bccd32b08ff3feea58ac449332b4c7e33a37 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -99,7 +99,7 @@ void GetDownloadFilePath(

base::FilePath directory(g_download_directory_for_tests ?

*g_download_directory_for_tests : download_directory);

-#if defined (OS_CHROMEOS)

+#if defined(OS_CHROMEOS)

// Do not use drive for extension downloads.

if (drive::util::IsUnderDriveMountPoint(directory))

directory = download_util::GetDefaultDownloadDirectory();

@@ -256,7 +256,7 @@ void WebstoreInstaller::Observe(int type,

return;

// TODO(rdevlin.cronin): Continue removing std::string errors and

- // replacing with string16

+ // replacing with string16. See crbug.com/71980.

const string16* error = content::Details<const string16>(details).ptr();

const std::string utf8_error = UTF16ToUTF8(*error);

if (download_url_ == crx_installer->original_download_url())

« no previous file with comments | « chrome/browser/extensions/process_management_browsertest.cc ('k') | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »