Issue 12379030: Remove "use_skia" variable from gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12379030: Remove "use_skia" variable from gyp. (Closed)

Created:
7 years, 9 months ago by teravest

Modified:
7 years, 9 months ago

Reviewers:
_cary, epoger, Nico, gene, (unused - use chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Remove "use_skia" variable from gyp. We've now switched to Skia from CoreGraphics entirely. See http://crbug.com/110881 for details. This change removes the vestigal "use_skia" variable. I'll send follow-up patches to remove uses of USE_SKIA from Chromium source. BUG=110881 TBR=gene Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186155

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -35 lines)			Patch
M	build/common.gypi	View	4 chunks	+3 lines, -15 lines	0 comments	Download
M	printing/printing.gyp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	skia/skia.gyp	View	2 chunks	+2 lines, -14 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/12379030/1

7 years, 9 months ago (2013-03-05 08:39:30 UTC) #6

Message was sent while issue was closed.

Change committed as 186155