Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: build/common.gypi

Issue 12379030: Remove "use_skia" variable from gyp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | printing/printing.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 82530c1145c0b240abab3bf2cf517b875740a994..4e3bc080bac4207de33c74df5d4192bfa0c3d5bb 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -418,15 +418,6 @@
'spdy_proxy_auth_property%' : '',
'conditions': [
- # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of
- # the 'conditions' clause. Initial attempts resulted in chromium and
- # webkit disagreeing on its setting.
- ['OS=="mac"', {
- 'use_skia%': 1,
- }, {
- 'use_skia%': 1,
- }],
-
# A flag for POSIX platforms
['OS=="win"', {
'os_posix%': 0,
@@ -685,7 +676,6 @@
'os_posix%': '<(os_posix)',
'use_glib%': '<(use_glib)',
'toolkit_uses_gtk%': '<(toolkit_uses_gtk)',
- 'use_skia%': '<(use_skia)',
'use_x11%': '<(use_x11)',
'use_gnome_keyring%': '<(use_gnome_keyring)',
'linux_fpic%': '<(linux_fpic)',
@@ -1671,6 +1661,9 @@
}],
],
},
+ # TODO(teravest): Remove this define once uses of USE_SKIA are cleaned up
+ # throughout the codebase.
+ 'defines' : ['USE_SKIA'],
'conditions': [
['OS=="linux" and linux_use_tcmalloc==1 and clang_type_profiler==1', {
'cflags_cc!': ['-fno-rtti'],
@@ -1876,11 +1869,6 @@
'ENABLE_EGLIMAGE=1',
],
}],
- ['use_skia==1', {
- 'defines': [
- 'USE_SKIA=1',
- ],
- }],
['asan==1 and OS=="win"', {
# Since asan on windows uses Syzygy, we need /PROFILE turned on to
# produce appropriate pdbs.
« no previous file with comments | « no previous file | printing/printing.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698