Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 12377065: Consolidate VIEW_ID_LOCATION_BAR into VIEW_ID_OMNIBOX. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
sail, Peter Kasting, sky
CC:
chromium-reviews, tfarina, sail+watch_chromium.org
Visibility:
Public.

Description

Consolidate VIEW_ID_LOCATION_BAR into VIEW_ID_OMNIBOX. VIEW_ID_OMNIBOX and VIEW_ID_LOCATION_BAR are redundant. Many tests needlessly exchange the IDs based on USE_AURA. Merge the two IDs as VIEW_ID_OMNIBOX and update tests. BUG=131660 TEST=No observable behavior changes; tests still pass. R=sail@chromium.org,pkasting@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -127 lines) Patch
M chrome/browser/browser_keyevents_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 20 chunks +23 lines, -38 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/view_id_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/action_box_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 12 chunks +13 lines, -44 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 8 chunks +9 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Scott and/or Peter; please take a look; thanks!
7 years, 9 months ago (2013-03-02 18:52:08 UTC) #1
Peter Kasting
LGTM but you may want to get at least a Mac person to glance at ...
7 years, 9 months ago (2013-03-02 22:36:44 UTC) #2
sail
cocoa/* LGTM
7 years, 9 months ago (2013-03-02 22:57:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12377065/1
7 years, 9 months ago (2013-03-02 23:54:23 UTC) #4
commit-bot: I haz the power
Presubmit check for 12377065-1 failed and returned exit status 1. INFO:root:Found 13 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-02 23:54:28 UTC) #5
msw
I just moved the include as cleanup, I didn't add it... landing manually.
7 years, 9 months ago (2013-03-03 00:00:45 UTC) #6
msw
7 years, 9 months ago (2013-03-03 00:10:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r185787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698