Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 12374054: Update and enable NativeMessagingTest.EchoConnect. (Closed)

Created:
7 years, 9 months ago by Sergey Ulanov
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Update and enable NativeMessagingTest.EchoConnect. The test was previously disable because it was flaky. Since then most of the implementation was rewritten, so it should be stable now. BUG=159754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185663

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -53 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 2 7 chunks +34 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_apitest.cc View 1 chunk +7 lines, -39 lines 0 comments Download
A chrome/browser/extensions/api/messaging/native_messaging_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/messaging/native_messaging_test_util.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
7 years, 9 months ago (2013-03-01 21:13:35 UTC) #1
Matt Perry
lgtm
7 years, 9 months ago (2013-03-01 21:38:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12374054/12002
7 years, 9 months ago (2013-03-01 23:58:24 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 02:20:51 UTC) #4
Message was sent while issue was closed.
Change committed as 185663

Powered by Google App Engine
This is Rietveld 408576698