Issue 12374054: Update and enable NativeMessagingTest.EchoConnect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12374054: Update and enable NativeMessagingTest.EchoConnect. (Closed)

Created:
7 years, 9 months ago by Sergey Ulanov

Modified:
7 years, 9 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update and enable NativeMessagingTest.EchoConnect. The test was previously disable because it was flaky. Since then most of the implementation was rewritten, so it should be stable now. BUG=159754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185663

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -53 lines)			Patch
M	chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc	View	1 2	7 chunks	+34 lines, -14 lines	0 comments	Download
M	chrome/browser/extensions/api/messaging/native_messaging_apitest.cc	View		1 chunk	+7 lines, -39 lines	0 comments	Download
A	chrome/browser/extensions/api/messaging/native_messaging_test_util.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/messaging/native_messaging_test_util.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12374054/12002

7 years, 9 months ago (2013-03-01 23:58:24 UTC) #3

Message was sent while issue was closed.

Change committed as 185663