Issue 12342037: Handle negative input in inlined Math.round on Intel CPUs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12342037: Handle negative input in inlined Math.round on Intel CPUs. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle negative input in inlined Math.round on Intel CPUs. R=jkummerow@chromium.org BUG=v8:2451 Committed: https://code.google.com/p/v8/source/detail?r=13764

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -72 lines)			Patch
M	src/assembler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.cc	View	1	3 chunks	+8 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+60 lines, -32 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+60 lines, -36 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-2451.js	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://chromiumcodereview.appspot.com/12342037/diff/1/src/assembler.cc File src/assembler.cc (right): https://chromiumcodereview.appspot.com/12342037/diff/1/src/assembler.cc#newcode1216 src/assembler.cc:1216: &double_constants.minus_one_half)); nit: for consistency with ...

7 years, 9 months ago (2013-02-27 14:40:07 UTC) #2

Yang

7 years, 9 months ago (2013-02-27 14:45:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13764 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12342037: Handle negative input in inlined Math.round on Intel CPUs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages