Handle negative input in inlined Math.round on Intel CPUs.

src/x64/lithium-codegen-x64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3468 matching lines @@
       __ movq(output_reg, input_reg);
       __ subq(output_reg, Immediate(1));
       DeoptimizeIf(overflow, instr->environment());
     }
     __ roundsd(xmm_scratch, input_reg, Assembler::kRoundDown);
     __ cvttsd2si(output_reg, xmm_scratch);
     __ cmpl(output_reg, Immediate(0x80000000));
     DeoptimizeIf(equal, instr->environment());
   } else {
     Label negative_sign, done;
-    // Deoptimize on negative inputs.
+    // Deoptimize on unordered.
     __ xorps(xmm_scratch, xmm_scratch);  // Zero the register.
     __ ucomisd(input_reg, xmm_scratch);
     DeoptimizeIf(parity_even, instr->environment());
     __ j(below, &negative_sign, Label::kNear);
 
     if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
       // Check for negative zero.
       Label positive_sign;
       __ j(above, &positive_sign, Label::kNear);
       __ movmskpd(output_reg, input_reg);
@@ skipping 23 matching lines @@
 
     __ bind(&done);
   }
 }
 
 
 void LCodeGen::DoMathRound(LUnaryMathOperation* instr) {
   const XMMRegister xmm_scratch = xmm0;
   Register output_reg = ToRegister(instr->result());
   XMMRegister input_reg = ToDoubleRegister(instr->value());
+  static int64_t one_half = V8_INT64_C(0x3FE0000000000000);  // 0.5
+  static int64_t minus_one_half = V8_INT64_C(0xBFE0000000000000);  // -0.5
 
-  Label done;
-  // xmm_scratch = 0.5
-  __ movq(kScratchRegister, V8_INT64_C(0x3FE0000000000000), RelocInfo::NONE64);
+  bool minus_zero_check =
+      instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero);
+
+  __ movq(kScratchRegister, one_half, RelocInfo::NONE64);
   __ movq(xmm_scratch, kScratchRegister);
-  Label below_half;
-  __ ucomisd(xmm_scratch, input_reg);
-  // If input_reg is NaN, this doesn't jump.
-  __ j(above, &below_half, Label::kNear);
-  // input = input + 0.5
-  // This addition might give a result that isn't the correct for
-  // rounding, due to loss of precision, but only for a number that's
-  // so big that the conversion below will overflow anyway.
-  __ addsd(xmm_scratch, input_reg);
-  // Compute Math.floor(input).
-  // Use truncating instruction (OK because input is positive).
-  __ cvttsd2si(output_reg, xmm_scratch);
-  // Overflow is signalled with minint.
-  __ cmpl(output_reg, Immediate(0x80000000));
-  DeoptimizeIf(equal, instr->environment());
-  __ jmp(&done);
 
-  __ bind(&below_half);
-  if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
-    // Bailout if negative (including -0).
-    __ movq(output_reg, input_reg);
-    __ testq(output_reg, output_reg);
-    DeoptimizeIf(negative, instr->environment());
+  if (CpuFeatures::IsSupported(SSE4_1) && !minus_zero_check) {
+    CpuFeatures::Scope scope(SSE4_1);
+    __ addsd(xmm_scratch, input_reg);
+    __ roundsd(xmm_scratch, input_reg, Assembler::kRoundDown);
+    __ cvttsd2si(output_reg, xmm_scratch);
+    // Overflow is signalled with minint.
+    __ cmpl(output_reg, Immediate(0x80000000));
+    __ RecordComment("D2I conversion overflow");
+    DeoptimizeIf(equal, instr->environment());
   } else {
-    // Bailout if below -0.5, otherwise round to (positive) zero, even
-    // if negative.
-    // xmm_scrach = -0.5
-    __ movq(kScratchRegister,
-            V8_INT64_C(0xBFE0000000000000),
-            RelocInfo::NONE64);
+    Label done, round_to_zero, below_one_half, do_not_compensate;
+    __ ucomisd(xmm_scratch, input_reg);
+    __ j(above, &below_one_half);
+
+    // CVTTSD2SI rounds towards zero, since 0.5 <= x, we use floor(0.5 + x).
+    __ addsd(xmm_scratch, input_reg);
+    __ cvttsd2si(output_reg, xmm_scratch);
+    // Overflow is signalled with minint.
+    __ cmpl(output_reg, Immediate(0x80000000));
+    __ RecordComment("D2I conversion overflow");
+    DeoptimizeIf(equal, instr->environment());
+    __ jmp(&done);
+
+    __ bind(&below_one_half);
+    __ movq(kScratchRegister, minus_one_half, RelocInfo::NONE64);
     __ movq(xmm_scratch, kScratchRegister);
+    __ ucomisd(xmm_scratch, input_reg);
+    __ j(below_equal, &round_to_zero);
+
+    // CVTTSD2SI rounds towards zero, we use ceil(x - (-0.5)) and then
+    // compare and compensate.
+    __ subsd(input_reg, xmm_scratch);
+    __ cvttsd2si(output_reg, input_reg);
+    // Catch minint due to overflow, and to prevent overflow when compensating.
+    __ cmpl(output_reg, Immediate(0x80000000));
+    __ RecordComment("D2I conversion overflow");
+    DeoptimizeIf(equal, instr->environment());
+
+    __ cvtlsi2sd(xmm_scratch, output_reg);
     __ ucomisd(input_reg, xmm_scratch);
-    DeoptimizeIf(below, instr->environment());
+    __ j(equal, &done, Label::kNear);
+    __ subl(output_reg, Immediate(1));
+    // No overflow because we already ruled out minint.
+    __ jmp(&done);
+
+    __ bind(&round_to_zero);
+    // We return 0 for the input range [+0, 0.5[, or [-0.5, 0.5[ if
+    // we can ignore the difference between a result of -0 and +0.
+    if (minus_zero_check) {
+      __ movq(output_reg, input_reg);
+      __ testq(output_reg, output_reg);
+      __ RecordComment("Minus zero");
+      DeoptimizeIf(negative, instr->environment());
+    }
+    __ Set(output_reg, 0);
+    __ bind(&done);
   }
-  __ xorl(output_reg, output_reg);
-
-  __ bind(&done);
 }
 
 
 void LCodeGen::DoMathSqrt(LUnaryMathOperation* instr) {
   XMMRegister input_reg = ToDoubleRegister(instr->value());
   ASSERT(ToDoubleRegister(instr->result()).is(input_reg));
   __ sqrtsd(input_reg, input_reg);
 }
 
 
@@ skipping 2212 matching lines @@
                                FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64