Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 12342008: Add GetAboutResource to DriveServiceInterface. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
satorux1, hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add GetAboutResource to DriveServiceInterface. Drive API v2 has two APIs to retrieve meta data: 1) "GetAboutResourceOperation" for quota, changestamp and root id. 2) "GetApplistOperation" for a list of installed apps. On the other hand, GDataWAPI has one API to retrieve them (except root id) at once, which is "GetAccountMeatadataOperation". It is possible to split the call of GetAccountMetadata into two (for about resource and for app list each). So, to fill the gap, GetAccountMetadata will be migrated into GetAboutResource and GetAppList. This CL just adds the method to the interface and some stub implementation only. The real implementation for each inheriting class and the client migration will be done in following CLs. BUG=174237 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184711

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sort class forward declaration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M chrome/browser/google_apis/drive_api_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_service_interface.h View 1 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-26 08:42:19 UTC) #1
kinaba
LGTM, but could you add some more specifics in the CL description? (By explaining that ...
7 years, 10 months ago (2013-02-26 09:18:04 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/12342008/diff/1/chrome/browser/google_apis/drive_service_interface.h File chrome/browser/google_apis/drive_service_interface.h (right): https://codereview.chromium.org/12342008/diff/1/chrome/browser/google_apis/drive_service_interface.h#newcode22 chrome/browser/google_apis/drive_service_interface.h:22: class AccountMetadataFeed; nit: Please sort these while you ...
7 years, 10 months ago (2013-02-26 09:24:21 UTC) #3
hidehiko
Thank you for your review. Updated the CL description. Submitting consecutively... https://codereview.chromium.org/12342008/diff/1/chrome/browser/google_apis/drive_service_interface.h File chrome/browser/google_apis/drive_service_interface.h (right): ...
7 years, 10 months ago (2013-02-26 09:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12342008/11001
7 years, 10 months ago (2013-02-26 13:53:45 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-26 19:56:20 UTC) #6
Message was sent while issue was closed.
Change committed as 184711

Powered by Google App Engine
This is Rietveld 408576698