Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 12340013: Disable ld.so.cache support (Closed)

Created:
7 years, 10 months ago by Roland McGrath
Modified:
7 years, 10 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

Disable ld.so.cache support The ld.so.cache file never exists in a NaCl manifest and there is no benefit to using such a file in the NaCl context. When using sel_ldr -a or the environment variable equivalent on a Linux host, searching for this file can hit the native host file and have unintended effects on library search. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3316 TEST= toolchain trybot R=bradnelson@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=b7d4c72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sysdeps/nacl/Makeconfig View 1 chunk +3 lines, -0 lines 0 comments Download
A sysdeps/nacl/dl-cache.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
7 years, 10 months ago (2013-02-21 23:06:41 UTC) #1
bradn
lgtm
7 years, 10 months ago (2013-02-21 23:08:45 UTC) #2
Roland McGrath
7 years, 10 months ago (2013-02-22 00:08:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rb7d4c72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698