Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 12335079: cc: Add synthetic invalidations for dropped recordings (Closed)

Created:
7 years, 10 months ago by enne (OOO)
Modified:
7 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, reveman
Visibility:
Public.

Description

cc: Add synthetic invalidations for dropped recordings Fix the case where a recording tile within a picture pile is dropped (due to it being far away and partially invalidated) and tiles within that recording tile (but not invalidated) are updated to point to a new picture pile that is unable to raster them. This patch adds synthetic invalidations that will drop tiles that no longer have recordings that can raster them. The downside of this is that content far away might get dropped unnecessarily if there are invalidations far away. Alternate approaches that were considered and not implemented: * Don't update the pile on tiles if the new pile can't raster the tile. The downside of this is that on every activation you have to scale every tile's content rect and then compare it against the pile's recorded region to see if it is still contained, and then not setting the pile if it isn't. * Don't drop far away recordings on invalidation and instead maintain a more complicated recorded region by subtracting out "unhandled" invalidations. This could make the recorded region much more complicated than it already is, making creation of new tilings much more expensive. NOTRY=true R=danakj@chromium.org BUG=173567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M cc/picture_layer_impl.cc View 1 chunk +21 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
7 years, 10 months ago (2013-02-25 23:16:06 UTC) #1
danakj
lgtm
7 years, 10 months ago (2013-02-25 23:39:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12335079/1
7 years, 10 months ago (2013-02-25 23:43:49 UTC) #3
enne (OOO)
android_dbg_triggered_tests (the only place this is tested) runs cleanly, and it builds on win, mac, ...
7 years, 10 months ago (2013-02-26 00:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12335079/1
7 years, 10 months ago (2013-02-26 00:19:00 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-26 00:20:57 UTC) #6
Message was sent while issue was closed.
Change committed as 184525

Powered by Google App Engine
This is Rietveld 408576698