Linux: Use the system ld instead of gold for 32-bit builds. Pass --no-keep-memory to prevent linker…

Linux: Use the system ld instead of gold for 32-bit builds. Pass --no-keep-memory to prevent linker OOM errors.

BUG=170262
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185374

[Paweł Hajdan Jr., 2013-02-21 15:08:25]

LGTM with comments.

Could you also reference bug 170262?

Thank you very much for helping here too!

https://codereview.chromium.org/12330042/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/12330042/diff/1/build/common.gypi#newcode546
build/common.gypi:546: ['OS=="linux" and target_arch=="x64"', {
I think it'd be better to say target_arch!="ia32", here and below. More
future-proof.

[Lei Zhang, 2013-02-21 19:41:40]

https://codereview.chromium.org/12330042/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/12330042/diff/1/build/common.gypi#newcode546
build/common.gypi:546: ['OS=="linux" and target_arch=="x64"', {
On 2013/02/21 15:08:25, Paweł Hajdan Jr. wrote:
> I think it'd be better to say target_arch!="ia32", here and below. More
> future-proof.

Actually, we only have pre-compiled gold binaries for ia32 and x64. Other
platforms have to work around this. e.g. for mipsel at line ~1039.

[commit-bot: I haz the power, 2013-02-21 19:47:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12330042/4001

[commit-bot: I haz the power, 2013-02-21 20:07:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Lei Zhang, 2013-02-21 21:44:43]

On 2013/02/21 20:07:20, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_chromeos_clang.
> http://build.chromium.org/p/tryserver.chromium/buildstatus?

Apparently nobody else does shared_build + ninja + GNU ld...

Gyp fix: https://codereview.chromium.org/12335018/

[commit-bot: I haz the power, 2013-02-22 06:54:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12330042/4001

[commit-bot: I haz the power, 2013-02-22 07:13:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Lei Zhang, 2013-02-28 00:40:56]

Next fix is: https://codereview.chromium.org/12377004/

I think this can land after the above lands.

[commit-bot: I haz the power, 2013-02-28 19:53:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12330042/4001

[commit-bot: I haz the power, 2013-03-01 00:11:27]

Change committed as 185374