Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: build/common.gypi

Issue 12330042: Linux: Use the system ld instead of gold for 32-bit builds. Pass --no-keep-memory to prevent linker… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 183611)
+++ build/common.gypi (working copy)
@@ -543,7 +543,7 @@
# linux_use_gold_binary: whether to use the binary checked into
# third_party/gold.
- ['OS=="linux"', {
+ ['OS=="linux" and target_arch=="x64"', {
'linux_use_gold_binary%': 1,
}, {
'linux_use_gold_binary%': 0,
@@ -552,7 +552,7 @@
# linux_use_gold_flags: whether to use build flags that rely on gold.
# On by default for x64 Linux. Temporarily off for ChromeOS as
# it failed on a buildbot.
- ['OS=="linux" and chromeos==0', {
+ ['OS=="linux" and target_arch=="x64" and chromeos==0', {
'linux_use_gold_flags%': 1,
}, {
'linux_use_gold_flags%': 0,
@@ -604,7 +604,6 @@
'armv7%': 1,
'linux_breakpad%': 0,
'linux_use_tcmalloc%': 0,
- 'linux_use_gold_flags%': 0,
# sysroot needs to be an absolute path otherwise it generates
# incorrect results when passed to pkg-config
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/arm-sysroot',
@@ -1036,8 +1035,6 @@
['target_arch=="mipsel"', {
'werror%': '',
'disable_nacl%': 1,
- 'linux_use_gold_binary%': 0,
- 'linux_use_gold_flags%': 0,
'nacl_untrusted_build%': 0,
'linux_use_tcmalloc%': 0,
'linux_breakpad%': 0,
@@ -2898,8 +2895,8 @@
'target_conditions': [
['_toolset=="target"', {
'ldflags': [
- # Workaround for linker OOM. http://crbug.com/160253.
- '-Wl,--no-keep-files-mapped',
+ # Workaround for linker OOM.
+ '-Wl,--no-keep-memory',
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698