Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

Issue 12328079: Update TestURLRequest constructor interface in extensions unit tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebase onto master. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
index d594c9fda8929ce712dc62d3534ddd39b6b52b4f..0a591846e5f39e57fce32abfef59f8110d41719c 100644
--- a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
@@ -36,7 +36,7 @@ TEST(ExtensionWebRequestHelpersTest, TestHideRequestForURL) {
// Check that requests are rejected based on the destination
for (size_t i = 0; i < arraysize(sensitive_urls); ++i) {
GURL sensitive_url(sensitive_urls[i]);
- net::TestURLRequest request(sensitive_url, NULL, &context);
+ net::TestURLRequest request(sensitive_url, NULL, &context, NULL);
EXPECT_TRUE(
WebRequestPermissions::HideRequest(extension_info_map.get(), &request))
<< sensitive_urls[i];
@@ -44,7 +44,7 @@ TEST(ExtensionWebRequestHelpersTest, TestHideRequestForURL) {
// Check that requests are accepted if they don't touch sensitive urls.
for (size_t i = 0; i < arraysize(non_sensitive_urls); ++i) {
GURL non_sensitive_url(non_sensitive_urls[i]);
- net::TestURLRequest request(non_sensitive_url, NULL, &context);
+ net::TestURLRequest request(non_sensitive_url, NULL, &context, NULL);
EXPECT_FALSE(
WebRequestPermissions::HideRequest(extension_info_map.get(), &request))
<< non_sensitive_urls[i];
@@ -54,14 +54,16 @@ TEST(ExtensionWebRequestHelpersTest, TestHideRequestForURL) {
// WebStore.
// Normally this request is not protected:
GURL non_sensitive_url("http://www.google.com/test.js");
- net::TestURLRequest non_sensitive_request(non_sensitive_url, NULL, &context);
+ net::TestURLRequest non_sensitive_request(
+ non_sensitive_url, NULL, &context, NULL);
EXPECT_FALSE(WebRequestPermissions::HideRequest(extension_info_map.get(),
&non_sensitive_request));
// If the origin is labeled by the WebStoreAppId, it becomes protected.
int process_id = 42;
int site_instance_id = 23;
int frame_id = 17;
- net::TestURLRequest sensitive_request(non_sensitive_url, NULL, &context);
+ net::TestURLRequest sensitive_request(
+ non_sensitive_url, NULL, &context, NULL);
ResourceRequestInfo::AllocateForTesting(&sensitive_request,
ResourceType::SCRIPT, NULL, process_id, frame_id);
extension_info_map->RegisterExtensionProcess(extension_misc::kWebStoreAppId,

Powered by Google App Engine
This is Rietveld 408576698