Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 12328079: Update TestURLRequest constructor interface in extensions unit tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebase onto master. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
index eb637cfbefacde4952234596ceead6b89980fb34..1f82ff1d0da47f5098bf8b7bdae1c3aad0a5a132 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
@@ -242,7 +242,7 @@ TEST_F(WebRequestRulesRegistryTest, AddRulesImpl) {
GURL http_url("http://www.example.com");
net::TestURLRequestContext context;
- net::TestURLRequest http_request(http_url, NULL, &context);
+ net::TestURLRequest http_request(http_url, NULL, &context, NULL);
WebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
matches = registry->GetMatches(request_data);
EXPECT_EQ(2u, matches.size());
@@ -255,7 +255,7 @@ TEST_F(WebRequestRulesRegistryTest, AddRulesImpl) {
EXPECT_TRUE(ContainsKey(matches_ids, std::make_pair(kExtensionId, kRuleId2)));
GURL foobar_url("http://www.foobar.com");
- net::TestURLRequest foobar_request(foobar_url, NULL, &context);
+ net::TestURLRequest foobar_request(foobar_url, NULL, &context, NULL);
request_data.request = &foobar_request;
matches = registry->GetMatches(request_data);
EXPECT_EQ(1u, matches.size());
@@ -381,7 +381,7 @@ TEST_F(WebRequestRulesRegistryTest, Precedences) {
GURL url("http://www.google.com");
net::TestURLRequestContext context;
- net::TestURLRequest request(url, NULL, &context);
+ net::TestURLRequest request(url, NULL, &context, NULL);
WebRequestData request_data(&request, ON_BEFORE_REQUEST);
std::list<LinkedPtrEventResponseDelta> deltas =
registry->CreateDeltas(NULL, request_data, false);
@@ -429,7 +429,7 @@ TEST_F(WebRequestRulesRegistryTest, Priorities) {
GURL url("http://www.google.com/index.html");
net::TestURLRequestContext context;
- net::TestURLRequest request(url, NULL, &context);
+ net::TestURLRequest request(url, NULL, &context, NULL);
WebRequestData request_data(&request, ON_BEFORE_REQUEST);
std::list<LinkedPtrEventResponseDelta> deltas =
registry->CreateDeltas(NULL, request_data, false);
@@ -482,7 +482,7 @@ TEST_F(WebRequestRulesRegistryTest, GetMatchesCheckFulfilled) {
GURL http_url("http://www.example.com");
net::TestURLRequestContext context;
- net::TestURLRequest http_request(http_url, NULL, &context);
+ net::TestURLRequest http_request(http_url, NULL, &context, NULL);
WebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
matches = registry->GetMatches(request_data);
EXPECT_EQ(1u, matches.size());
@@ -538,7 +538,7 @@ TEST_F(WebRequestRulesRegistryTest, GetMatchesDifferentUrls) {
for (size_t i = 0; i < arraysize(matchingRuleIds); ++i) {
// Construct the inputs.
- net::TestURLRequest http_request(urls[i], NULL, &context);
+ net::TestURLRequest http_request(urls[i], NULL, &context, NULL);
WebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
http_request.set_first_party_for_cookies(firstPartyUrls[i]);
// Now run both rules on the input.

Powered by Google App Engine
This is Rietveld 408576698