Fix create_installer_archive.py to be more flexible with output directory names

Fix create_installer_archive.py to correctly determine
the debug/release mode regardless of x86/x64 platform
and also pick up the right CRT DLLs

BUG=166496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184872

[grt (UTC plus 2), 2013-02-26 02:29:13]

https://codereview.chromium.org/12326117/diff/2001/chrome/tools/build/win/cre...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/2001/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:365:
"Debug_NonRedist/x86/Microsoft.*.DebugCRT/*.dll")
should "x86" here be "x64" for a 64-bit build?

https://codereview.chromium.org/12326117/diff/2001/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:368: "C:/Program Files
(x86)/Microsoft Visual Studio */VC/redist/x86/"
same here (but only the 2nd x86)

[Will Harris, 2013-02-26 21:48:57]

I have a patch for these and am waiting on the compile to test that it works -
hopefully will be able to cl upload later today

[Will Harris, 2013-02-26 22:31:38]

now we're smarter with determining and pulling the
correct CRT DLLs.

[robertshield, 2013-02-27 00:48:30]

https://codereview.chromium.org/12326117/diff/6001/chrome/tools/build/win/cre...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/6001/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:368: "C:/Program Files
(x86)/Microsoft Visual Studio */VC/redist/" + \
is the '\' needed here?

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
chrome/tools/build/win/create_installer_archive.py:375: # check we are are on a
64bit system by existance of WOW64 dir
nit: existance -> existence

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
chrome/tools/build/win/create_installer_archive.py:380: print ("Warning: could
not find x64 CRT DLLs on x86 system")
If we hit this, will the resulting installer package be usable? If not, should
we raise an error here.

[Will Harris, 2013-02-27 01:16:08]

fixes as per code review, thanks for the alacrity

https://codereview.chromium.org/12326117/diff/6001/chrome/tools/build/win/cre...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/6001/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:368: "C:/Program Files
(x86)/Microsoft Visual Studio */VC/redist/" + \
On 2013/02/27 00:48:30, robertshield wrote:
> is the '\' needed here?

Done.

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
chrome/tools/build/win/create_installer_archive.py:375: # check we are are on a
64bit system by existance of WOW64 dir
On 2013/02/27 00:48:31, robertshield wrote:
> nit: existance -> existence

Done.

https://codereview.chromium.org/12326117/diff/10001/chrome/tools/build/win/cr...
chrome/tools/build/win/create_installer_archive.py:380: print ("Warning: could
not find x64 CRT DLLs on x86 system")
On 2013/02/27 00:48:31, robertshield wrote:
> If we hit this, will the resulting installer package be usable? If not, should
> we raise an error here. 

install package is useful - on line 393 a second warning is printed and all that
happens is that it might not run on a vanilla system - I decided to continue
here and not abort for this reason

[robertshield, 2013-02-27 01:23:09]

https://codereview.chromium.org/12326117/diff/4005/chrome/tools/build/win/cre...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/4005/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:382: print ("Warning: could
not find x64 CRT DLLs on x86 system.")
come to think of it, won't this raise a symbol not found error (I forget the
exact name) on line 391 or 393 since sys_dll_dir won't be defined if we hit this
code branch?

[Will Harris, 2013-02-27 01:38:59]

fixes to potential undefined variable

https://codereview.chromium.org/12326117/diff/4005/chrome/tools/build/win/cre...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/12326117/diff/4005/chrome/tools/build/win/cre...
chrome/tools/build/win/create_installer_archive.py:382: print ("Warning: could
not find x64 CRT DLLs on x86 system.")
On 2013/02/27 01:23:09, robertshield wrote:
> come to think of it, won't this raise a symbol not found error (I forget the
> exact name) on line 391 or 393 since sys_dll_dir won't be defined if we hit
this
> code branch?

Done.

[robertshield, 2013-02-27 01:42:32]

lgtm

[commit-bot: I haz the power, 2013-02-27 01:45:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/12326117/10005

[commit-bot: I haz the power, 2013-02-27 04:27:30]

Change committed as 184872