chrome/installer/mini_installer.gyp - Issue 12326117: Fix create_installer_archive.py to be more flexible with output directory names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer.gyp

Issue 12326117: Fix create_installer_archive.py to be more flexible with output directory names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nit related to potentially undefied variable under rare circumstances Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/mini_installer.gyp

diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp

index 34cb6473b8fbe6f3497d90ba501b17f818d7efeb..2c2945b5b7741380aa27ec98ffd737c9ee4351f1 100644

--- a/chrome/installer/mini_installer.gyp

+++ b/chrome/installer/mini_installer.gyp

@@ -235,6 +235,13 @@

'<(PRODUCT_DIR)/nacl64.exe',

'<(PRODUCT_DIR)/nacl_irt_x86_32.nexe',

+ 'variables': {

+ 'target_arch_flag': '--target_arch=x64',

+ },

+ }, {

+ 'variables': {

+ 'target_arch_flag': '--target_arch=x86',

+ },

}],

'inputs': [

@@ -267,6 +274,7 @@

'<(enable_hidpi_flag)',

'<(enable_touch_ui_flag)',

'<(component_build_flag)',

+ '<(target_arch_flag)',

# TODO(sgk): may just use environment variables

#'--distribution=$(CHROMIUM_BUILD)',

'--distribution=_google_chrome',

« no previous file with comments | « no previous file | chrome/installer/mini_installer.gypi » ('j') | no next file with comments »