Issue 12321108: Revert r13699 "Debugger: ScopeMirror has N^2 algorithm when building closure mirrors." because of W…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321108: Revert r13699 "Debugger: ScopeMirror has N^2 algorithm when building closure mirrors." because of W… (Closed)

Created:
7 years, 10 months ago by ulan

Modified:
7 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert r13699 "Debugger: ScopeMirror has N^2 algorithm when building closure mirrors." because of WebKit crashes. BUG=v8:2554 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13714

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -38 lines)			Patch
M	src/objects.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/runtime.cc	View	5 chunks	+36 lines, -8 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

ulan

PTAL. Link to the original CL: https://chromiumcodereview.appspot.com/12326009

7 years, 10 months ago (2013-02-25 11:54:59 UTC) #1

ulan

7 years, 10 months ago (2013-02-25 11:56:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13714 (presubmit successful).