Issue 12326009: Debugger: ScopeMirror has N^2 algorithm when building closure mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12326009: Debugger: ScopeMirror has N^2 algorithm when building closure mirrors. (Closed)

Created:
7 years, 10 months ago by Yang

Modified:
7 years, 10 months ago

Reviewers:
yurys, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Debugger: ScopeMirror has N^2 algorithm when building closure mirrors. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13699

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -36 lines)			Patch
M	src/objects.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	5 chunks	+8 lines, -36 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2013/02/20 13:57:18, Yang wrote: This is a copy of https://codereview.appspot.com/7384043 LGTM.

7 years, 10 months ago (2013-02-20 13:59:49 UTC) #2

Yang

7 years, 10 months ago (2013-02-20 14:12:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r13699 (presubmit successful).