base: Move MemoryMappedFile out of file_util.h and into its own header file.

base: Move MemoryMappedFile out of file_util.h and into its own header file.

BUG=175002
TEST=base_unittests
R=brettw@chromium.org
TBR=erikwright@chromium.org,tommi@chromium.org,fischman@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184356

[tfarina, 2013-02-21 22:36:06]

A gift for you :)

Please, take a look.

Thanks,

[brettw, 2013-02-22 21:28:15]

Yay!

https://codereview.chromium.org/12321062/diff/8002/chrome/installer/test/reso...
File chrome/installer/test/resource_updater.cc (right):

https://codereview.chromium.org/12321062/diff/8002/chrome/installer/test/reso...
chrome/installer/test/resource_updater.cc:10: #include "base/file_util.h"
I wonder if you checked whether some of these files only depended on file_util
for the MemoryMappedFile so the old include could be deleted now?

[tfarina, 2013-02-22 22:58:53]

https://codereview.chromium.org/12321062/diff/8002/chrome/installer/test/reso...
File chrome/installer/test/resource_updater.cc (right):

https://codereview.chromium.org/12321062/diff/8002/chrome/installer/test/reso...
chrome/installer/test/resource_updater.cc:10: #include "base/file_util.h"
On 2013/02/22 21:28:15, brettw wrote:
> I wonder if you checked whether some of these files only depended on file_util
> for the MemoryMappedFile so the old include could be deleted now?
Done. I ran 'git grep file_util" on all files in this CL.

[brettw, 2013-02-22 23:02:56]

https://codereview.chromium.org/12321062/diff/1060/base/files/memory_mapped_f...
File base/files/memory_mapped_file_win.cc (right):

https://codereview.chromium.org/12321062/diff/1060/base/files/memory_mapped_f...
base/files/memory_mapped_file_win.cc:29: DLOG(ERROR) << "Couldn't open " <<
file_name.AsUTF8Unsafe();
It's not clear why you changed this.

[tfarina, 2013-02-22 23:05:18]

On 2013/02/22 23:02:56, brettw wrote:
>
https://codereview.chromium.org/12321062/diff/1060/base/files/memory_mapped_f...
> File base/files/memory_mapped_file_win.cc (right):
> 
>
https://codereview.chromium.org/12321062/diff/1060/base/files/memory_mapped_f...
> base/files/memory_mapped_file_win.cc:29: DLOG(ERROR) << "Couldn't open " <<
> file_name.AsUTF8Unsafe();
> It's not clear why you changed this.
Yes, I'm using Scott's suggestion. I could have used using ::operator<<; // Pick
the right operator<< below. as it's done in
base/files/file_path_watcher_win.cc:220 though.

https://groups.google.com/a/chromium.org/forum/?hl=en&fromgroups=#!topic/chro...

[brettw, 2013-02-22 23:27:39]

lgtm

[brettw, 2013-02-22 23:28:08]

BTW if you do a move and change anything in the future other than just moving,
it would be good to point that out. I don't necessarily review the moved code.

[tfarina, 2013-02-23 01:58:58]

TBRing the following owners for the respective directories:

chrome_frame -> erikwright
courgette -> tommi
media -> fischman
ui -> ben

The other directories are already covered by Brett ownership.

[Ami GONE FROM CHROMIUM, 2013-02-23 02:01:36]

LGTM for *media*

[commit-bot: I haz the power, 2013-02-24 18:08:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12321062/10064

[commit-bot: I haz the power, 2013-02-24 18:08:44]

Failed to apply patch for base/i18n/icu_util.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/i18n/icu_util.cc
  Hunk #1 FAILED at 14.
  1 out of 2 hunks FAILED -- saving rejects to file base/i18n/icu_util.cc.rej

Patch:       base/i18n/icu_util.cc
Index: base/i18n/icu_util.cc
diff --git a/base/i18n/icu_util.cc b/base/i18n/icu_util.cc
index
25fe8c140eb60079bbf7b8793969ad3ec666533e..18c68a6bb9137faa8faeddccac8cec7bdbdb554f
100644
--- a/base/i18n/icu_util.cc
+++ b/base/i18n/icu_util.cc
@@ -14,6 +14,7 @@
 
 #include "base/file_path.h"
 #include "base/file_util.h"
+#include "base/files/memory_mapped_file.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
@@ -111,7 +112,7 @@ bool Initialize() {
 
   // Chrome doesn't normally shut down ICU, so the mapped data shouldn't ever
   // be released.
-  static file_util::MemoryMappedFile mapped_file;
+  static base::MemoryMappedFile mapped_file;
   if (!mapped_file.IsValid()) {
     // Assume it is in the framework bundle's Resources directory.
     FilePath data_path =

[commit-bot: I haz the power, 2013-02-24 18:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12321062/5048

[commit-bot: I haz the power, 2013-02-24 19:48:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12321062/8016

[commit-bot: I haz the power, 2013-02-24 21:55:49]

Change committed as 184356

[tommi (sloooow) - chröme, 2013-02-25 12:49:01]

belated lgtm for courgette.

[Ben Goodger (Google), 2013-02-25 16:04:02]

ui lgtm