chrome/installer/util/chrome_frame_operations.h - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_frame_operations.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Style changes; removing passing of BrowserDistribution for experiments; specializing LaunchBrowserU… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/chrome_browser_operations.cc ('K') | « chrome/installer/util/chrome_browser_operations.cc ('k') | chrome/installer/util/chrome_frame_operations.cc » ('j') | chrome/installer/util/user_experiment.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/chrome_frame_operations.h

diff --git a/chrome/installer/util/chrome_frame_operations.h b/chrome/installer/util/chrome_frame_operations.h

index dac2016e718ba9b371ddcb84674f12ab5e3337c3..a3488afa9bc312745f748cc8186b4371bfcdcbf0 100644

--- a/chrome/installer/util/chrome_frame_operations.h

+++ b/chrome/installer/util/chrome_frame_operations.h

@@ -50,6 +50,11 @@ class ChromeFrameOperations : public ProductOperations {

const base::FilePath& target_exe,

ShellUtil::ShortcutProperties* properties) const OVERRIDE;

+ virtual void LaunchUserExperiment(const base::FilePath& setup_path,

+ const std::set<std::wstring>& options,

+ InstallStatus status,

+ bool system_level) const OVERRIDE;

protected:

void NormalizeOptions(std::set<std::wstring>* options) const;