Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 12320014: Switch Pepper Linux to use shared USB<->native key conversion table. (Closed)

Created:
7 years, 10 months ago by Wez
Modified:
7 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, James Su, darin-cc_chromium.org, penghuang+watch_chromium.org, sail+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Switch Pepper Linux to use shared USB<->native key conversion table. This fixes issues with the Linux table lagging behind the shared version, and: - Marks the UsbKeycodeToNativeKeycode helper "inline", for now, to avoid the warning on unused static functions, and since it is sufficiently simple to make sense to inline. - Tweaks the types of the array iterator in the other platform-specific implementations. BUG=177278, 118432, 165704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184318

Patch Set 1 #

Patch Set 2 : Fix static-initializer issue and clean up some more. #

Patch Set 3 : Try again. #

Patch Set 4 : Fix missed kInvalidKeycode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -179 lines) Patch
M remoting/host/desktop_session_agent.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/event_executor_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/event_executor_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/event_executor_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/keycodes/usb_keycode_map.h View 1 2 chunks +17 lines, -3 lines 0 comments Download
M ui/base/keycodes/usb_keycode_map_unittest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/usb_key_code_conversion_linux.cc View 1 2 chunks +5 lines, -150 lines 0 comments Download
M webkit/plugins/ppapi/usb_key_code_conversion_mac.cc View 1 1 chunk +2 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/usb_key_code_conversion_win.cc View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Wez
7 years, 10 months ago (2013-02-20 21:21:35 UTC) #1
garykac
lgtm
7 years, 10 months ago (2013-02-20 22:22:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/1
7 years, 10 months ago (2013-02-20 22:50:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 12320014-1 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-20 22:51:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/1
7 years, 10 months ago (2013-02-21 03:43:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=113901
7 years, 10 months ago (2013-02-21 05:04:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/1
7 years, 10 months ago (2013-02-21 06:44:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) build http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=21406
7 years, 10 months ago (2013-02-21 08:03:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/1
7 years, 10 months ago (2013-02-21 18:38:16 UTC) #9
commit-bot: I haz the power
Change committed as 183841
7 years, 10 months ago (2013-02-21 18:51:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/11
7 years, 10 months ago (2013-02-23 05:31:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12320014/20004
7 years, 10 months ago (2013-02-23 05:50:00 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 14:14:26 UTC) #13
Message was sent while issue was closed.
Change committed as 184318

Powered by Google App Engine
This is Rietveld 408576698