Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: tools/telemetry/telemetry/core/chrome/tab_list_backend.py

Issue 12319081: Remove tab_list_backend.Reset. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: dtu feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/chrome/cros_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/chrome/tab_list_backend.py
===================================================================
--- tools/telemetry/telemetry/core/chrome/tab_list_backend.py (revision 184144)
+++ tools/telemetry/telemetry/core/chrome/tab_list_backend.py (working copy)
@@ -24,12 +24,6 @@
def Init(self):
self._UpdateTabList()
- def Reset(self):
- # TODO(hartmanng): Remove this method when crbug.com/166886 is fixed.
- self.Init()
- self._tab_list = []
- self._tab_dict = weakref.WeakValueDictionary()
-
def New(self, timeout):
assert self._browser_backend.supports_tab_control
@@ -78,9 +72,7 @@
# TODO(hartmanng): crbug.com/166886 (uncomment the following assert and
# remove the extra None check when _ListTabs is fixed):
# assert tab_info is not None
- if tab_info is None:
- return None
- return tab_info['url']
+ return tab_info['url'] if tab_info else None
def __iter__(self):
self._UpdateTabList()
« no previous file with comments | « tools/telemetry/telemetry/core/chrome/cros_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698