Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

Issue 12319081: Remove tab_list_backend.Reset. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: dtu feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/chrome/tab_list_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py
===================================================================
--- tools/telemetry/telemetry/core/chrome/cros_browser_backend.py (revision 184154)
+++ tools/telemetry/telemetry/core/chrome/cros_browser_backend.py (working copy)
@@ -93,11 +93,6 @@
def SetBrowser(self, browser):
super(CrOSBrowserBackend, self).SetBrowser(browser)
- # TODO(hartmanng): crbug.com/166886 (Remove these temporary hacks when
- # _ListTabs is fixed)
-
- self._tab_list_backend.Reset()
-
# Wait for the login screen to disappear.
def TabNotOobeLogin():
tab = self._tab_list_backend.Get(0, None)
@@ -105,10 +100,7 @@
util.WaitFor(TabNotOobeLogin, 20)
# Wait for the startup window to launch.
- def StartupWindowLaunched():
- self._tab_list_backend.Reset()
- return len(self._tab_list_backend) != 0
- util.WaitFor(StartupWindowLaunched, 20)
+ util.WaitFor(lambda: len(self._tab_list_backend) != 0, 20)
# Close the startup window.
self._tab_list_backend[0].Close()
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/chrome/tab_list_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698