Delete the extensions i18n message map when extension unload is received.

Delete the extensions i18n message map cache when extension unload is received.

Invalidate the messages map for the extension in case the extension is reloaded
with a new messages map.

BUG=53628
TEST=Load an unpacked extension with i18n messages used in a content script.
Open a window or tab that loads the i18n messages. Change the messages.json
file. Reload the extension and the messages should be changed.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188460

[Devlin, 2013-02-22 19:59:07]

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:180: {
Bracket on same line as function name.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:182: // Create Extension
whos messages.json file is to be updated.
Make comments grammatically correct.
"Create _an_ Extension _whose_ message.json file will be updated."

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:183: base::FilePath extdir;
As a rule, we try to avoid abbreviating variable names.  Some exceptions are
made for _very_ common ones (e.g., URL) and some slip through the cracks.  But
try to keep them full names; e.g. extension_dir.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:198: const
extensions::Extension*extension = LoadExtension(extdir);
Space between Extension* and extension.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:202: //Test messages.json
file is loaded and the i18n message is loaded.
Space after comment beginning (i.e. "// Test...")
"Test _that the_ messages.json file...."

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:210:
ui_test_utils::GetCurrentTabTitle(browser(),&title);
Space between arguments.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:222: //Check i18n message is
also changed.
"Check _that the_ i18n message..."

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:230:
EXPECT_EQ(std::string("SECONDMESSAGE"), UTF16ToUTF8(title));
There seems to be too many newlines between 204 and 230 - can some of these be
grouped logically?

https://codereview.chromium.org/12319073/diff/1/chrome/common/extensions/mess...
File chrome/common/extensions/message_bundle.h (right):

https://codereview.chromium.org/12319073/diff/1/chrome/common/extensions/mess...
chrome/common/extensions/message_bundle.h:168: // Erases messages map that
matches given extension_id.
"Erases the L10nMessagesMap for the given |extension_id|." would be clearer.

https://codereview.chromium.org/12319073/diff/1/chrome/renderer/extensions/di...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/renderer/extensions/di...
chrome/renderer/extensions/dispatcher.cc:518: // Invalidates messages map for id
incase extension is reloaded with
"Invalidates _the_ messages map for the extension _in case_ the extension is
reloaded with _a_ new messages map."

https://codereview.chromium.org/12319073/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/content_scripts/message_reload1/messages.json
(right):

https://codereview.chromium.org/12319073/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/content_scripts/message_reload1/messages.json:3:
"message": "SECONDMESSAGE"
Maybe differentiate this .json file's name so it's clear it's the second one?

[Patrick Riordan, 2013-02-26 05:05:20]

Fixed up style.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:180: {
On 2013/02/22 19:59:07, D Cronin wrote:
> Bracket on same line as function name.

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:182: // Create Extension
whos messages.json file is to be updated.
On 2013/02/22 19:59:07, D Cronin wrote:
> Make comments grammatically correct.
> "Create _an_ Extension _whose_ message.json file will be updated."

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:183: base::FilePath extdir;
On 2013/02/22 19:59:07, D Cronin wrote:
> As a rule, we try to avoid abbreviating variable names.  Some exceptions are
> made for _very_ common ones (e.g., URL) and some slip through the cracks.  But
> try to keep them full names; e.g. extension_dir.

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:198: const
extensions::Extension*extension = LoadExtension(extdir);
On 2013/02/22 19:59:07, D Cronin wrote:
> Space between Extension* and extension.

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:202: //Test messages.json
file is loaded and the i18n message is loaded.
On 2013/02/22 19:59:07, D Cronin wrote:
> Space after comment beginning (i.e. "// Test...")
> "Test _that the_ messages.json file...."

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:210:
ui_test_utils::GetCurrentTabTitle(browser(),&title);
On 2013/02/22 19:59:07, D Cronin wrote:
> Space between arguments.

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:222: //Check i18n message is
also changed.
On 2013/02/22 19:59:07, D Cronin wrote:
> "Check _that the_ i18n message..."

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:230:
EXPECT_EQ(std::string("SECONDMESSAGE"), UTF16ToUTF8(title));
On 2013/02/22 19:59:07, D Cronin wrote:
> There seems to be too many newlines between 204 and 230 - can some of these be
> grouped logically?

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/common/extensions/mess...
File chrome/common/extensions/message_bundle.h (right):

https://codereview.chromium.org/12319073/diff/1/chrome/common/extensions/mess...
chrome/common/extensions/message_bundle.h:168: // Erases messages map that
matches given extension_id.
On 2013/02/22 19:59:07, D Cronin wrote:
> "Erases the L10nMessagesMap for the given |extension_id|." would be clearer.

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/renderer/extensions/di...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/renderer/extensions/di...
chrome/renderer/extensions/dispatcher.cc:518: // Invalidates messages map for id
incase extension is reloaded with
On 2013/02/22 19:59:07, D Cronin wrote:
> "Invalidates _the_ messages map for the extension _in case_ the extension is
> reloaded with _a_ new messages map."

Done.

https://codereview.chromium.org/12319073/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/content_scripts/message_reload1/messages.json
(right):

https://codereview.chromium.org/12319073/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/content_scripts/message_reload1/messages.json:3:
"message": "SECONDMESSAGE"
On 2013/02/22 19:59:07, D Cronin wrote:
> Maybe differentiate this .json file's name so it's clear it's the second one?

Done.

[Devlin, 2013-02-26 05:57:12]

Two other things:
1) If there's no message_reload2, there's no reason to call this message_reload1
instead of message_reload. :)
2) I think this test is more suited to the i18n apitest
(chrome/browser/extensions/api/i18n/i18n_apitest.cc).  Do you agree?

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:182: // Create Extension
whos messages.json file is to be updated.
On 2013/02/26 05:05:20, patrickriordan177 wrote:
> On 2013/02/22 19:59:07, D Cronin wrote:
> > Make comments grammatically correct.
> > "Create _an_ Extension _whose_ message.json file will be updated."
> 
> Done.

Still need to fix 'whos' to 'whose'. (I might also change "is to be" to "will
be", but that's personal preference, so it's up to you) :)

https://codereview.chromium.org/12319073/diff/8001/chrome/browser/extensions/...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/8001/chrome/browser/extensions/...
chrome/browser/extensions/content_script_apitest.cc:186:
"content_scripts/message_reload1/manifest.json"),
It's better form to append one thing at a time; i.e.
test_data_dir_.AppendASCII("content_scripts")
              .AppendASCII("message_reload")
              .AppendASCII("manifest.json")

This is because AppendASCII does things other than a literal append, and will
also use OS-specific path preferences (for instance, on Windows, backslashes are
used in paths).

(I realize it doesn't do this elsewhere in this file, but it probably should,
and it is more common practice to do so.)

[Patrick Riordan, 2013-02-27 18:30:16]

Changed message_reload1 to i18nUpdate
I agree that looks like a much better place. Changed.

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/1/chrome/browser/extensions/con...
chrome/browser/extensions/content_script_apitest.cc:182: // Create Extension
whos messages.json file is to be updated.
On 2013/02/26 05:57:12, D Cronin wrote:
> On 2013/02/26 05:05:20, patrickriordan177 wrote:
> > On 2013/02/22 19:59:07, D Cronin wrote:
> > > Make comments grammatically correct.
> > > "Create _an_ Extension _whose_ message.json file will be updated."
> > 
> > Done.
> 
> Still need to fix 'whos' to 'whose'. (I might also change "is to be" to "will
> be", but that's personal preference, so it's up to you) :)

Done.

https://codereview.chromium.org/12319073/diff/8001/chrome/browser/extensions/...
File chrome/browser/extensions/content_script_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/8001/chrome/browser/extensions/...
chrome/browser/extensions/content_script_apitest.cc:186:
"content_scripts/message_reload1/manifest.json"),
On 2013/02/26 05:57:12, D Cronin wrote:
> It's better form to append one thing at a time; i.e.
> test_data_dir_.AppendASCII("content_scripts")
>               .AppendASCII("message_reload")
>               .AppendASCII("manifest.json")
> 
> This is because AppendASCII does things other than a literal append, and will
> also use OS-specific path preferences (for instance, on Windows, backslashes
are
> used in paths).
> 
> (I realize it doesn't do this elsewhere in this file, but it probably should,
> and it is more common practice to do so.)

Done.

[Devlin, 2013-02-27 23:10:41]

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/i18n/i18n_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:3: // found in the LICENSE
file.
Newline after the license

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:7: #include
"chrome/test/base/ui_test_utils.h"
We have an "include what you use" rule (i.e., anything used that's not included
in the header file).  While we can occasionally make exceptions for _very_ basic
includes (logging, string, etc), we should always include larger things (e.g.,
extension.h, base/file_path.h, etc).

https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
File chrome/common/extensions/message_bundle.cc (right):

https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
chrome/common/extensions/message_bundle.cc:346: }
nit: Insert newline here.

[Patrick Riordan, 2013-03-01 17:28:54]

Patch 5 untitled on accident. Title should be Updated includes and fixed sytle.
On 2013/02/27 23:10:41, D Cronin wrote:
>
https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
> File chrome/browser/extensions/api/i18n/i18n_apitest.cc (right):
> 
>
https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
> chrome/browser/extensions/api/i18n/i18n_apitest.cc:3: // found in the LICENSE
> file.
> Newline after the license
> 
>
https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
> chrome/browser/extensions/api/i18n/i18n_apitest.cc:7: #include
> "chrome/test/base/ui_test_utils.h"
> We have an "include what you use" rule (i.e., anything used that's not
included
> in the header file).  While we can occasionally make exceptions for _very_
basic
> includes (logging, string, etc), we should always include larger things (e.g.,
> extension.h, base/file_path.h, etc).
> 
>
https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
> File chrome/common/extensions/message_bundle.cc (right):
> 
>
https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
> chrome/common/extensions/message_bundle.cc:346: }
> nit: Insert newline here.

[Patrick Riordan, 2013-03-01 17:29:22]

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/i18n/i18n_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:3: // found in the LICENSE
file.
On 2013/02/27 23:10:41, D Cronin wrote:
> Newline after the license

Done.

https://codereview.chromium.org/12319073/diff/11/chrome/browser/extensions/ap...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:7: #include
"chrome/test/base/ui_test_utils.h"
On 2013/02/27 23:10:41, D Cronin wrote:
> We have an "include what you use" rule (i.e., anything used that's not
included
> in the header file).  While we can occasionally make exceptions for _very_
basic
> includes (logging, string, etc), we should always include larger things (e.g.,
> extension.h, base/file_path.h, etc).
Changed to include everything used.

https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
File chrome/common/extensions/message_bundle.cc (right):

https://codereview.chromium.org/12319073/diff/11/chrome/common/extensions/mes...
chrome/common/extensions/message_bundle.cc:346: }
On 2013/02/27 23:10:41, D Cronin wrote:
> nit: Insert newline here.

Done.

[Devlin, 2013-03-04 17:07:15]

lgtm

[Patrick Riordan, 2013-03-04 18:44:00]

On 2013/03/04 17:07:15, D Cronin wrote:
> lgtm

I took out #include base/file_path.h, it turns out to be base/files/file_path.h
instead. After fixing it I thought that it's reasonable to expect that
base/file_util.h will always include file_path.h. Although if you think
otherwise then I'll put it in.

[Devlin, 2013-03-08 20:04:55]

Hey Yoyo, this is a CL from one of our new guys, Patrick.  Mind taking a look?

[Yoyo Zhou, 2013-03-08 22:17:50]

Thanks for the patch. It looks good for the most part; the biggest thing to fix
is the CL description. Comments below.

https://codereview.chromium.org/12319073/diff/35001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/12319073/diff/35001/AUTHORS#newcode158
AUTHORS:158: Patrick Riordan <patrickriordan177@gmail.com>
I think it's traditional to append to the end of this file.

https://codereview.chromium.org/12319073/diff/35001/chrome/browser/extensions...
File chrome/browser/extensions/api/i18n/i18n_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/browser/extensions...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:23:
file_util::CreateNewTempDirectory(base::FilePath::StringType(),
Use ScopedTempDir so your temp directory is deleted at the end of the test.

https://codereview.chromium.org/12319073/diff/35001/chrome/renderer/extension...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/renderer/extension...
chrome/renderer/extensions/dispatcher.cc:519: // Invalidates the messages map
for the extension in case the extension is
By the way, the CL description is way too verbose and doesn't get to the point.
You don't need to explain caches from scratch; you can assume the reader has a
basic understanding of Chromium. You can replace lines 2-5 with this, basically,
and include the word "cache" after "message map" in the first line.

Also, it improves readability to put a newline after line 1.

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json
(right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json:2:
"testMessage":{
nit: space after :

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/manifest.json (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/manifest.json:2: "name" : "i18n
Message Test",
nit: no space before :

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/manifest.json:6: "matches" : [
"<all_urls>" ],
nit: you don't need to buffer the contents of [] with spaces

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/messages2.json (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/messages2.json:2:
"testMessage":{
nit: space after :

[Patrick Riordan, 2013-03-11 17:32:42]

https://codereview.chromium.org/12319073/diff/35001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/12319073/diff/35001/AUTHORS#newcode158
AUTHORS:158: Patrick Riordan <patrickriordan177@gmail.com>
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> I think it's traditional to append to the end of this file.

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/browser/extensions...
File chrome/browser/extensions/api/i18n/i18n_apitest.cc (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/browser/extensions...
chrome/browser/extensions/api/i18n/i18n_apitest.cc:23:
file_util::CreateNewTempDirectory(base::FilePath::StringType(),
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> Use ScopedTempDir so your temp directory is deleted at the end of the test.

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/renderer/extension...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/renderer/extension...
chrome/renderer/extensions/dispatcher.cc:519: // Invalidates the messages map
for the extension in case the extension is
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> By the way, the CL description is way too verbose and doesn't get to the
point.
> You don't need to explain caches from scratch; you can assume the reader has a
> basic understanding of Chromium. You can replace lines 2-5 with this,
basically,
> and include the word "cache" after "message map" in the first line.
> 
> Also, it improves readability to put a newline after line 1.

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json
(right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json:2:
"testMessage":{
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> nit: space after :

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/manifest.json (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/manifest.json:2: "name" : "i18n
Message Test",
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> nit: no space before :

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/manifest.json:6: "matches" : [
"<all_urls>" ],
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> nit: you don't need to buffer the contents of [] with spaces

Done.

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/i18nUpdate/messages2.json (right):

https://codereview.chromium.org/12319073/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/i18nUpdate/messages2.json:2:
"testMessage":{
On 2013/03/08 22:17:50, Yoyo Zhou wrote:
> nit: space after :

Done.

[Yoyo Zhou, 2013-03-11 19:44:25]

LGTM
minor nit: I would write the CL description as "Delete..." and "Invalidate..."
instead of "Deletes..." and "Invalidates..." but that's up to you.

[commit-bot: I haz the power, 2013-03-13 16:29:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/12319073/4...

[commit-bot: I haz the power, 2013-03-13 16:30:02]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 229.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
47a01dd4469bb003ecdad7c7954e17d3fd5847a9..8557ba1f30fce360c2792460aa62e6565befc0ea
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -229,3 +229,4 @@ Horia Olaru <horia.olaru@gmail.com>
 Opera Software ASA <*@opera.com>
 Johannes Rudolph <johannes.rudolph@googlemail.com>
 Sam Larison <qufighter@gmail.com>
+Patrick Riordan <patrickriordan177@gmail.com>

[commit-bot: I haz the power, 2013-03-13 19:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/12319073/5...

[commit-bot: I haz the power, 2013-03-13 19:13:16]

Presubmit check for 12319073-56001 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  chrome/test/data/extensions/api_test/i18nUpdate/contentscript.js

Presubmit checks took 1.9s to calculate.

[commit-bot: I haz the power, 2013-03-13 19:25:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/12319073/6...

[commit-bot: I haz the power, 2013-03-13 21:32:52]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-15 17:30:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/12319073/6...

[commit-bot: I haz the power, 2013-03-15 18:11:14]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-15 19:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/12319073/6...

[commit-bot: I haz the power, 2013-03-15 20:12:22]

Change committed as 188460