Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/browser/extensions/api/i18n/i18n_apitest.cc

Issue 12319073: Delete the extensions i18n message map when extension unload is received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge AUTHORS Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | chrome/common/extensions/message_bundle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/i18n/i18n_apitest.cc
diff --git a/chrome/browser/extensions/api/i18n/i18n_apitest.cc b/chrome/browser/extensions/api/i18n/i18n_apitest.cc
index 1f358137d0e37098abec66e3390c2f5f4dbb07bf..1255946d802eef49c119ce583e37c5b3529364ee 100644
--- a/chrome/browser/extensions/api/i18n/i18n_apitest.cc
+++ b/chrome/browser/extensions/api/i18n/i18n_apitest.cc
@@ -2,9 +2,65 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_apitest.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "net/test/test_server.h"
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18N) {
ASSERT_TRUE(StartTestServer());
ASSERT_TRUE(RunExtensionTest("i18n")) << message_;
}
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18NUpdate) {
+ ASSERT_TRUE(StartTestServer());
+ // Create an Extension whose messages.json file will be updated.
+ base::ScopedTempDir extension_dir;
+ ASSERT_TRUE(extension_dir.CreateUniqueTempDir());
+ file_util::CopyFile(
+ test_data_dir_.AppendASCII("i18nUpdate")
+ .AppendASCII("manifest.json"),
+ extension_dir.path().AppendASCII("manifest.json"));
+ file_util::CopyFile(
+ test_data_dir_.AppendASCII("i18nUpdate")
+ .AppendASCII("contentscript.js"),
+ extension_dir.path().AppendASCII("contentscript.js"));
+ file_util::CopyDirectory(
+ test_data_dir_.AppendASCII("i18nUpdate")
+ .AppendASCII("_locales"),
+ extension_dir.path().AppendASCII("_locales"),
+ true);
+
+ const extensions::Extension* extension = LoadExtension(extension_dir.path());
+
+ ResultCatcher catcher;
+
+ // Test that the messages.json file is loaded and the i18n message is loaded.
+ ui_test_utils::NavigateToURL(
+ browser(), test_server()->GetURL("file/extensions/test_file.html"));
+ EXPECT_TRUE(catcher.GetNextResult());
+
+ string16 title;
+ ui_test_utils::GetCurrentTabTitle(browser(), &title);
+ EXPECT_EQ(std::string("FIRSTMESSAGE"), UTF16ToUTF8(title));
+
+ // Change messages.json file and reload extension.
+ file_util::CopyFile(
+ test_data_dir_.AppendASCII("i18nUpdate")
+ .AppendASCII("messages2.json"),
+ extension_dir.path().AppendASCII("_locales/en/messages.json"));
+ ReloadExtension(extension->id());
+
+ // Check that the i18n message is also changed.
+ ui_test_utils::NavigateToURL(
+ browser(), test_server()->GetURL("file/extensions/test_file.html"));
+ EXPECT_TRUE(catcher.GetNextResult());
+
+ ui_test_utils::GetCurrentTabTitle(browser(), &title);
+ EXPECT_EQ(std::string("SECONDMESSAGE"), UTF16ToUTF8(title));
+}
« no previous file with comments | « AUTHORS ('k') | chrome/common/extensions/message_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698