[content shell] don't require a user action for focus/blur events during layout tests

[content shell] don't require a user action for focus/blur events during layout tests

Many layout tests assume that e.g. window.focus() will change the focus instantly. This
is not the case, and those tests will need to be updated.

BUG=111316
TEST=layout tests that change the focus and listen to focus events work.
R=piman@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185017

[piman, 2013-02-26 21:11:35]

LGTM+nit

https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.cc:384: static bool
g_require_user_gesture_for_focus = true;
nit: could we move this to RenderThreadImpl to avoid more globals?

[jochen (gone - plz use gerrit), 2013-02-26 21:14:00]

On 2013/02/26 21:11:35, piman wrote:
> LGTM+nit
> 
>
https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
> File content/renderer/render_view_impl.cc (right):
> 
>
https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
> content/renderer/render_view_impl.cc:384: static bool
> g_require_user_gesture_for_focus = true;
> nit: could we move this to RenderThreadImpl to avoid more globals?

You mean with a getter and a setter on RenderThreadImpl? Sure, will do!

[piman, 2013-02-26 21:16:55]

On Tue, Feb 26, 2013 at 1:14 PM, <jochen@chromium.org> wrote:

> On 2013/02/26 21:11:35, piman wrote:
>
>> LGTM+nit
>>
>
>
> https://codereview.chromium.**org/12317133/diff/1/content/**
>
renderer/render_view_impl.cc<https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_impl.cc>
>
>> File content/renderer/render_view_**impl.cc (right):
>>
>
>
> https://codereview.chromium.**org/12317133/diff/1/content/**
>
renderer/render_view_impl.cc#**newcode384<https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_impl.cc#newcode384>
>
>> content/renderer/render_view_**impl.cc:384: static bool
>> g_require_user_gesture_for_**focus = true;
>> nit: could we move this to RenderThreadImpl to avoid more globals?
>>
>
> You mean with a getter and a setter on RenderThreadImpl? Sure, will do!
>

Yeah, that's what I had in mind. Thanks!

>
>
https://codereview.chromium.**org/12317133/<https://codereview.chromium.org/1...
>

[jochen (gone - plz use gerrit), 2013-02-27 16:24:14]

https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/12317133/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.cc:384: static bool
g_require_user_gesture_for_focus = true;
On 2013/02/26 21:11:35, piman wrote:
> nit: could we move this to RenderThreadImpl to avoid more globals?

Done.

[commit-bot: I haz the power, 2013-02-27 16:25:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/12317133/6001

[commit-bot: I haz the power, 2013-02-27 20:22:03]

Change committed as 185017