Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 12316096: ARM: Make DoStoreKeyedFixedDoubleArray faster; don't allow conditional Vmov (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
Reviewers:
ulan, Rodolph Perfetta
CC:
v8-dev
Visibility:
Public.

Description

ARM: Make DoStoreKeyedFixedDoubleArray faster; don't allow conditional Vmov This patch makes us generate faster code for DoStoreKeyedFixedDoubleArray, by using a branch rather than a conditional Vmov instruction. Conditional VFP instructions are not a great idea in general, and it was especially bad in this case because Vmov expands to a bunch of instructions. For this reason, the patch also removes the 'cond' parameter from Vmov. Thanks to Rodolph for pointing me to this! BUG=none Committed: https://code.google.com/p/v8/source/detail?r=13722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
This makes for faster writes to unboxed double arrays. On the matmul benchmark that I ...
7 years, 10 months ago (2013-02-25 12:10:16 UTC) #1
ulan
The change looks good to me. We can land it after getting Rodolph's review.
7 years, 10 months ago (2013-02-25 12:47:05 UTC) #2
Rodolph Perfetta
LGTM.
7 years, 10 months ago (2013-02-25 15:01:58 UTC) #3
ulan
Thans, LGTM, landing.
7 years, 10 months ago (2013-02-25 16:15:14 UTC) #4
ulan
7 years, 10 months ago (2013-02-25 16:15:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r13722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698