Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 12316096: ARM: Make DoStoreKeyedFixedDoubleArray faster; don't allow conditional Vmov (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4454 matching lines...) Expand 10 before | Expand all | Expand 10 after
4465 : Operand(key, LSL, shift_size); 4465 : Operand(key, LSL, shift_size);
4466 __ add(scratch, elements, operand); 4466 __ add(scratch, elements, operand);
4467 if (!key_is_constant) { 4467 if (!key_is_constant) {
4468 __ add(scratch, scratch, 4468 __ add(scratch, scratch,
4469 Operand(FixedDoubleArray::kHeaderSize - kHeapObjectTag)); 4469 Operand(FixedDoubleArray::kHeaderSize - kHeapObjectTag));
4470 } 4470 }
4471 4471
4472 if (instr->NeedsCanonicalization()) { 4472 if (instr->NeedsCanonicalization()) {
4473 // Check for NaN. All NaNs must be canonicalized. 4473 // Check for NaN. All NaNs must be canonicalized.
4474 __ VFPCompareAndSetFlags(value, value); 4474 __ VFPCompareAndSetFlags(value, value);
4475 Label after_canonicalization;
4476
4475 // Only load canonical NaN if the comparison above set the overflow. 4477 // Only load canonical NaN if the comparison above set the overflow.
4478 __ b(vc, &after_canonicalization);
4476 __ Vmov(value, 4479 __ Vmov(value,
4477 FixedDoubleArray::canonical_not_the_hole_nan_as_double(), 4480 FixedDoubleArray::canonical_not_the_hole_nan_as_double());
4478 no_reg, vs); 4481
4482 __ bind(&after_canonicalization);
4479 } 4483 }
4480 4484
4481 __ vstr(value, scratch, instr->additional_index() << element_size_shift); 4485 __ vstr(value, scratch, instr->additional_index() << element_size_shift);
4482 } 4486 }
4483 4487
4484 4488
4485 void LCodeGen::DoStoreKeyedFixedArray(LStoreKeyed* instr) { 4489 void LCodeGen::DoStoreKeyedFixedArray(LStoreKeyed* instr) {
4486 Register value = ToRegister(instr->value()); 4490 Register value = ToRegister(instr->value());
4487 Register elements = ToRegister(instr->elements()); 4491 Register elements = ToRegister(instr->elements());
4488 Register key = instr->key()->IsRegister() ? ToRegister(instr->key()) 4492 Register key = instr->key()->IsRegister() ? ToRegister(instr->key())
(...skipping 1836 matching lines...) Expand 10 before | Expand all | Expand 10 after
6325 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 6329 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
6326 __ ldr(result, FieldMemOperand(scratch, 6330 __ ldr(result, FieldMemOperand(scratch,
6327 FixedArray::kHeaderSize - kPointerSize)); 6331 FixedArray::kHeaderSize - kPointerSize));
6328 __ bind(&done); 6332 __ bind(&done);
6329 } 6333 }
6330 6334
6331 6335
6332 #undef __ 6336 #undef __
6333 6337
6334 } } // namespace v8::internal 6338 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698