Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 12316081: Revert 180288 (Closed)

Created:
7 years, 10 months ago by raymes
Modified:
7 years, 10 months ago
Reviewers:
Bernhard Bauer, yzshen1
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Revert 180288 This is to test the hypothesis that this change is responsible for a memory increase in the plugin process. It is a temporary change and should be reverted within the coming days. BUG=176330 > Fix enable state of Pepper Flash. > > Component-updated and bundled Pepper Flash share the same enable state. When > reading from the Preferences file, the previous code ignored the enable state > if it was associated with the component-updated path. That was wrong because if > the component-updated Flash was newer, the enable state would be recorded with > that path. The outcome was that everytime users restarted the browser, Pepper > Flash was enabled, even if they disabled it before. > > TBR=bauerb@chromium.org > BUG=150596 > TEST=None > > Review URL: https://codereview.chromium.org/12079044 TBR=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184265

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/plugins/plugin_prefs.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
raymes
7 years, 10 months ago (2013-02-22 23:29:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/12316081/4001
7 years, 10 months ago (2013-02-22 23:35:13 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-23 00:02:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/12316081/10003
7 years, 10 months ago (2013-02-23 00:32:01 UTC) #4
commit-bot: I haz the power
Change committed as 184265
7 years, 10 months ago (2013-02-23 02:38:22 UTC) #5
Bernhard Bauer
Has this had any results? FWIW, I doubt a change in the browser code has ...
7 years, 10 months ago (2013-02-26 07:13:49 UTC) #6
raymes
No this had no effect (which we expected). All the blamelists pointed to this change ...
7 years, 9 months ago (2013-02-26 16:43:03 UTC) #7
raymes
7 years, 9 months ago (2013-02-27 16:32:16 UTC) #8
It turns out this change probably did have an effect on memory in the
plugin! The uma data hadn't caught up yet. See the associated bug.

On Tue, Feb 26, 2013 at 8:43 AM, Raymes Khoury <raymes@chromium.org> wrote:
> No this had no effect (which we expected). All the blamelists pointed
> to this change though so we gave it a shot anyway.
>
> On Mon, Feb 25, 2013 at 11:13 PM,  <bauerb@chromium.org> wrote:
>> Has this had any results? FWIW, I doubt a change in the browser code has any
>> result on memory usage in the plugin process.
>>
>> https://chromiumcodereview.appspot.com/12316081/

Powered by Google App Engine
This is Rietveld 408576698