Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 12316005: cc: fix HudLayer to be sized by device (Closed)

Created:
7 years, 10 months ago by egraether
Modified:
7 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: fix HudLayer to be sized by device This change switches the HudLayer to be sized based on deviceViewPort and deviceScaleFactor instead of layoutViewPort. This way the hudLayer's content does not go offscreen in case --enable-fixed-layout is used. BUG=173603 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183623

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp vars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M cc/heads_up_display_layer.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
Looks good! Some temp vars would make this nicer IMO. Let's find out if it ...
7 years, 10 months ago (2013-02-20 02:46:08 UTC) #1
egraether
New patch uses temp vars and this fix got verified on Nexus 4 & 10.
7 years, 10 months ago (2013-02-20 18:45:55 UTC) #2
danakj
LGTM
7 years, 10 months ago (2013-02-20 18:50:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egraether@chromium.org/12316005/3001
7 years, 10 months ago (2013-02-20 18:51:50 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 21:26:56 UTC) #5
Message was sent while issue was closed.
Change committed as 183623

Powered by Google App Engine
This is Rietveld 408576698