Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 12314032: [content shell] enable touch events for layout tests (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
Reviewers:
tony, Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] enable touch events for layout tests Also add the touchDragDropEnabled setting to webpreferences. This will make fast/events/touch tests pass. BUG=111316 R=tony@chromium.org,creis@chromium.org TEST=touch tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/shell/webkit_test_helpers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-21 14:57:27 UTC) #1
jochen (gone - plz use gerrit)
Tony, please review everything Charlie, please OWNER stamp the IPC macro change in content/public/common
7 years, 10 months ago (2013-02-21 14:58:05 UTC) #2
tony
LGTM. Which layout tests does this fix?
7 years, 10 months ago (2013-02-21 18:38:37 UTC) #3
Charlie Reis
LGTM.
7 years, 10 months ago (2013-02-22 07:03:05 UTC) #4
jochen (gone - plz use gerrit)
this will make fast/events/touch tests pass
7 years, 10 months ago (2013-02-22 21:14:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12314032/1
7 years, 10 months ago (2013-02-22 21:16:17 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 10 months ago (2013-02-23 00:43:05 UTC) #7
tony
On 2013/02/23 00:43:05, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
7 years, 10 months ago (2013-02-23 00:56:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12314032/1
7 years, 10 months ago (2013-02-23 00:57:09 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 01:07:38 UTC) #10
Message was sent while issue was closed.
Change committed as 184242

Powered by Google App Engine
This is Rietveld 408576698