Split profile-generator

Split profile-generator

CPU profile code and Heap Snapshot code are completely unrelated to each other.
So we can extract heap snapshot part into separate file.
No functional changes.


BUG=none
TEST=none

Committed: https://code.google.com/p/v8/source/detail?r=13706

[yurys, 2013-02-21 09:07:44]

https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:32: #include "heap-profiler.h"
It is already included in "heap-snapshot-generator-inl.h"

https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h#newco...
src/profile-generator.h:64: class StringsStorage {
StringStorage is used by both cpu profile and heap snapshot generators. Should
we move it into something like profile-generator-common.h?

[loislo, 2013-02-21 09:16:16]

On 2013/02/21 09:07:44, Yury Semikhatsky wrote:
> https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.cc
> File src/heap-snapshot-generator.cc (right):
> 
>
https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.c...
> src/heap-snapshot-generator.cc:32: #include "heap-profiler.h"
> It is already included in "heap-snapshot-generator-inl.h"

I'll fix that

> 
> https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h
> File src/profile-generator.h (right):
> 
>
https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h#newco...
> src/profile-generator.h:64: class StringsStorage {
> StringStorage is used by both cpu profile and heap snapshot generators. Should
> we move it into something like profile-generator-common.h?

I'll do that in a separate patch.

[yurys, 2013-02-21 11:34:57]

lgtm

[Yang, 2013-02-21 11:35:48]

LGTM.

https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h#newco...
src/profile-generator.h:64: class StringsStorage {
On 2013/02/21 09:07:44, Yury Semikhatsky wrote:
> StringStorage is used by both cpu profile and heap snapshot generators. Should
> we move it into something like profile-generator-common.h?

Or move it to utils.h

[loislo, 2013-02-21 12:10:53]

Committed patchset #1 manually as r13706 (presubmit successful).