cc: Without valid frame, delegated renderer layer is not drawable

cc: Without valid frame, delegated renderer layer is not drawable

When the frame has no render passes, or is empty sized, then the
delegated renderer layer passes an empty DelegatedFrameData to the
impl tree and is considered !drawsContent().

Tests:
LayerTreeHostDelegatedTestLayerUsesFrameDamage.runSingleThread
LayerTreeHostDelegatedTestLayerUsesFrameDamage.runMultiThread

R=piman
BUG=123444
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185329

[piman, 2013-02-27 20:51:03]

lgtm, thanks!

https://codereview.chromium.org/12310179/diff/1/cc/delegated_renderer_layer_i...
File cc/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/12310179/diff/1/cc/delegated_renderer_layer_i...
cc/delegated_renderer_layer_impl.cc:55: gfx::RectF damage_in_layer;
nit: you can now move this and the setUpdateRect inside the if.

[danakj, 2013-02-27 20:53:45]

https://codereview.chromium.org/12310179/diff/1/cc/delegated_renderer_layer_i...
File cc/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/12310179/diff/1/cc/delegated_renderer_layer_i...
cc/delegated_renderer_layer_impl.cc:55: gfx::RectF damage_in_layer;
On 2013/02/27 20:51:03, piman wrote:
> nit: you can now move this and the setUpdateRect inside the if.

Thanks! I've already uploaded another version with that :D (also deleted the
old_stuff above now unusued.)

[danakj, 2013-02-27 21:04:01]

+slavi

[piman, 2013-02-27 21:04:35]

lgtm

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
File cc/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
cc/delegated_renderer_layer_impl.cc:50: if (new_root_pass) {
pushing even slightly further, you can save an if by testing
!frame_data->render_pass_list.empty() here and only fetching
frame_data->render_pass_list.back() inside the if.

[danakj, 2013-02-27 21:05:26]

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
File cc/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
cc/delegated_renderer_layer_impl.cc:50: if (new_root_pass) {
On 2013/02/27 21:04:35, piman wrote:
> pushing even slightly further, you can save an if by testing
> !frame_data->render_pass_list.empty() here and only fetching
> frame_data->render_pass_list.back() inside the if.

True! Let's see how the remap CL looks, I can do that there.

[danakj, 2013-02-27 21:40:45]

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
File cc/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/12310179/diff/3001/cc/delegated_renderer_laye...
cc/delegated_renderer_layer_impl.cc:50: if (new_root_pass) {
On 2013/02/27 21:05:27, danakj wrote:
> On 2013/02/27 21:04:35, piman wrote:
> > pushing even slightly further, you can save an if by testing
> > !frame_data->render_pass_list.empty() here and only fetching
> > frame_data->render_pass_list.back() inside the if.
> 
> True! Let's see how the remap CL looks, I can do that there.

Oh right, this is waiting on CQ from another CL anyways. Done!

[piman, 2013-02-27 21:55:28]

lgtm

[commit-bot: I haz the power, 2013-02-28 18:34:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12310179/7003

[commit-bot: I haz the power, 2013-02-28 21:46:25]

Change committed as 185329