Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Side by Side Diff: cc/delegated_renderer_layer.cc

Issue 12310179: cc: Without valid frame, delegated renderer layer is not drawable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: morecleanup Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/delegated_renderer_layer.h ('k') | cc/delegated_renderer_layer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/delegated_renderer_layer.h" 5 #include "cc/delegated_renderer_layer.h"
6 6
7 #include "cc/delegated_frame_data.h" 7 #include "cc/delegated_frame_data.h"
8 #include "cc/delegated_renderer_layer_impl.h" 8 #include "cc/delegated_renderer_layer_impl.h"
9 9
10 namespace cc { 10 namespace cc {
11 11
12 scoped_refptr<DelegatedRendererLayer> DelegatedRendererLayer::Create() { 12 scoped_refptr<DelegatedRendererLayer> DelegatedRendererLayer::Create() {
13 return scoped_refptr<DelegatedRendererLayer>(new DelegatedRendererLayer()); 13 return scoped_refptr<DelegatedRendererLayer>(new DelegatedRendererLayer());
14 } 14 }
15 15
16 DelegatedRendererLayer::DelegatedRendererLayer() 16 DelegatedRendererLayer::DelegatedRendererLayer()
17 : Layer() { 17 : Layer() {
18 } 18 }
19 19
20 DelegatedRendererLayer::~DelegatedRendererLayer() {} 20 DelegatedRendererLayer::~DelegatedRendererLayer() {}
21 21
22 scoped_ptr<LayerImpl> DelegatedRendererLayer::createLayerImpl( 22 scoped_ptr<LayerImpl> DelegatedRendererLayer::createLayerImpl(
23 LayerTreeImpl* tree_impl) { 23 LayerTreeImpl* tree_impl) {
24 return DelegatedRendererLayerImpl::Create( 24 return DelegatedRendererLayerImpl::Create(
25 tree_impl, m_layerId).PassAs<LayerImpl>(); 25 tree_impl, m_layerId).PassAs<LayerImpl>();
26 } 26 }
27 27
28 bool DelegatedRendererLayer::drawsContent() const {
29 return !frame_size_.IsEmpty();
30 }
31
28 void DelegatedRendererLayer::pushPropertiesTo(LayerImpl* impl) { 32 void DelegatedRendererLayer::pushPropertiesTo(LayerImpl* impl) {
29 Layer::pushPropertiesTo(impl); 33 Layer::pushPropertiesTo(impl);
30 34
31 DelegatedRendererLayerImpl* delegated_impl = 35 DelegatedRendererLayerImpl* delegated_impl =
32 static_cast<DelegatedRendererLayerImpl*>(impl); 36 static_cast<DelegatedRendererLayerImpl*>(impl);
33 37
34 delegated_impl->SetDisplaySize(display_size_); 38 delegated_impl->SetDisplaySize(display_size_);
35 39
36 if (frame_data_) 40 if (frame_data_) {
37 delegated_impl->SetFrameData(frame_data_.Pass(), damage_in_frame_); 41 if (frame_size_.IsEmpty()) {
38 42 scoped_ptr<DelegatedFrameData> empty_frame(new DelegatedFrameData);
39 damage_in_frame_ = gfx::RectF(); 43 delegated_impl->SetFrameData(empty_frame.Pass(), gfx::Rect());
44 } else {
45 delegated_impl->SetFrameData(frame_data_.Pass(), damage_in_frame_);
46 }
47 frame_data_.reset();
48 damage_in_frame_ = gfx::RectF();
49 }
40 } 50 }
41 51
42 void DelegatedRendererLayer::SetDisplaySize(gfx::Size size) { 52 void DelegatedRendererLayer::SetDisplaySize(gfx::Size size) {
43 if (display_size_ == size) 53 if (display_size_ == size)
44 return; 54 return;
45 display_size_ = size; 55 display_size_ = size;
46 setNeedsCommit(); 56 setNeedsCommit();
47 } 57 }
48 58
49 void DelegatedRendererLayer::SetFrameData( 59 void DelegatedRendererLayer::SetFrameData(
50 scoped_ptr<DelegatedFrameData> new_frame_data) { 60 scoped_ptr<DelegatedFrameData> new_frame_data) {
51 frame_data_ = new_frame_data.Pass(); 61 frame_data_ = new_frame_data.Pass();
52 if (!frame_data_->render_pass_list.empty()) { 62 if (!frame_data_->render_pass_list.empty()) {
53 RenderPass* root_pass = frame_data_->render_pass_list.back(); 63 RenderPass* root_pass = frame_data_->render_pass_list.back();
54 damage_in_frame_.Union(root_pass->damage_rect); 64 damage_in_frame_.Union(root_pass->damage_rect);
65 frame_size_ = root_pass->output_rect.size();
66 } else {
67 frame_size_ = gfx::Size();
55 } 68 }
56 setNeedsCommit(); 69 setNeedsCommit();
57 } 70 }
58 71
59 } // namespace cc 72 } // namespace cc
OLDNEW
« no previous file with comments | « cc/delegated_renderer_layer.h ('k') | cc/delegated_renderer_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698